Unity-Technologies / 2d-extras

Fun 2D Stuff that we'd like to share!
Other
1.54k stars 342 forks source link

Cs1061 IS SELECTED ERROR. Nothing is fixing it. #308

Open Sabolf opened 3 years ago

Sabolf commented 3 years ago

Assets\2d-extras-master\Editor\Tiles\RuleTile\RuleTileEditor.cs(341,22): error CS1061: 'ReorderableList' does not contain a definition for 'IsSelected' and no accessible extension method 'IsSelected' accepting a first argument of type 'ReorderableList' could be found (are you missing a using directive or an assembly reference?)

This is the error code that I keep receiving. I am doing a Stacks tutorial on unity. One of the steps is to download the 2d extras file. I have tried the master version and the 2020.3.15 version. Every time I try to import it into unity I get the same error code. I have even have tried renaming the file to "com.unity.2d.tilemap.extras" which was stated in a tutorial video on youtube. I also have tried dragging into Packages and Assets. I dont know what to do.

Sabolf commented 3 years ago

I have Unity Version 2020.3.2

ChuanXin-Unity commented 3 years ago

Hi, could you try using https://github.com/Unity-Technologies/2d-extras/tree/2020.3 for your Unity version?

You can add it in using the Unity Package Manager by entering "https://github.com/Unity-Technologies/2d-extras.git#2020.3" when adding a package by name.

Sabolf commented 3 years ago

[Package Manager Window] Unable to add package [https://github.com/Unity-Technologies/2d-extras.git#2020.3]: No 'git' executable was found. Please install Git on your system then restart Unity and Unity Hub UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()

[Package Manager Window] Cannot perform upm operation: Unable to add package [https://github.com/Unity-Technologies/2d-extras.git#2020.3]: No 'git' executable was found. Please install Git on your system then restart Unity and Unity Hub [NotFound]. UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()

[Package Manager Window] Error adding package: https://github.com/Unity-Technologies/2d-extras.git#2020.3. UnityEditor.EditorApplication:Internal_CallUpdateFunctions ()

I went to package manager and added from Git Url and it responded with this. I downloaded the 2020.3 zip file from your link and Extracted it as well on the desktop so that the files would be able to be accessed without being stuck behind the zip wall. I tried dragging the file into packages and assets again but same result. On the video it give him the option to clone or something but for it just says code in the green box before I download the Zip.

ChuanXin-Unity commented 3 years ago

You would need to install Git (https://git-scm.com/) to use the method I recommended above unfortunately.

As you do not have Git installed, but have downloaded the 2020.3 zip file, could you try the following instead:

This will install the package from the zip file.

Also, ensure you do not have any duplicates in your Project, eg. you do not need a copy in Assets\2d-extras-master\ if you have installed the package this way.

Let us know if that works!

mediamagnet commented 3 years ago

Hi,

I had the same problem checking it out and switching branches seems to have cleared the issue.

Sabolf commented 3 years ago

I cannot explain why this is not working. So, I downloaded Git from the link. Is there an extra option after? After I downloaded and installed it I went to the package handler option. I then entered the link into the search by ULR option. I got the same Error saying Git was not Installed, but it is installed, so I do not know If I am missing a option. I went into the Package handler and installed the json file and it actually installed. It says that 2D Tilemap Extras has been installed. Now I keep getting a error though in the bottom. It is the

C:\Users\sabol\Desktop\12345\2d-extras-master\Editor\Tiles\RuleTile\RuleTileEditor.cs(347,82): error CS1061: 'ReorderableList' does not contain a definition for 'IsSelected' and no accessible extension method 'IsSelected' accepting a first argument of type 'ReorderableList' could be found (are you missing a using directive or an assembly reference?)

C:\Users\sabol\Desktop\12345\2d-extras-master\Editor\Tiles\RuleTile\RuleTileEditor.cs(341,22): error CS1061: 'ReorderableList' does not contain a definition for 'IsSelected' and no accessible extension method 'IsSelected' accepting a first argument of type 'ReorderableList' could be found (are you missing a using directive or an assembly reference?)

C:\Users\sabol\Desktop\12345\2d-extras-master\Editor\Tiles\RuleTile\RuleTileEditor.cs(327,26): error CS1061: 'ReorderableList' does not contain a definition for 'IsSelected' and no accessible extension method 'IsSelected' accepting a first argument of type 'ReorderableList' could be found (are you missing a using directive or an assembly reference?)

ChuanXin-Unity commented 3 years ago

I think the problem may be that the GitHub interface is downloading the master version despite you switching to the 2020.3 branch. When you extract the zip file, could you check what version of the package is listed in the package.json file and share it here?

ChuanXin-Unity commented 3 years ago

@Sabolf

Would it be possible for you to try to download and extract the package from the following link? https://github.com/Unity-Technologies/2d-extras/archive/refs/tags/1.8.1-preview.zip

You can follow the steps again to install the package:

Hopefully this works this time!

Sabolf commented 3 years ago

I just checked and you're right! It says master on the .json file. I swear I keep switching it to my version the 2020.3, there has to be some sort of override happening. Alright, so I followed your steps. It installed successfully I think. No code errors at the bottom, but. It has in big yellow letters at the top "preview packages in use". I did a little research into that and it says that they are unstable or beta versions and shouldn't be used to production and only be used for testing? I did however find the animated tile option, which is new an added, I just had to search for it in a different spot of the menu.

Sabolf commented 3 years ago

My question is, is there an error right now with the website? Is every link downloading the master file? Also is the temporary?

ChuanXin-Unity commented 3 years ago

It seems to be the behaviour across all GitHub repositories (or at least based on the one non-Unity repository I checked). I believe it was not like this before, and you could download a zip of the branch you were in. If it applies across all GitHub repositories, it may not be temporary unfortunately.

Sabolf commented 3 years ago

Doesnt that ultimately make the entire asset package unusable ? Like how do I get it to work with master if we are stuck with this.

ChuanXin-Unity commented 3 years ago

The master branch is targeted for the current latest version of the Unity Editor, which is 2021.1. For previous versions, you should use the branch specifically targeting that version of the Unity Editor, eg. 2019.4 for 2019.4 version of the Unity Editor. The reason for this is that the public APIs can change for each version of the Unity Editor and are not compatible with prior versions, as they may not be backported.

On a side note, GitHub fixed the Download Zip option for different branches, so if you select the 2019.4 branch and download the zip for that, you will get a zip of the 2019.4 branch.

Hope that helps, and do let us know if you need more details and clarifications!

living2room commented 2 years ago

Thanks