search

Unity-Technologies / UniversalRenderingExamples

This project contains a collection of Custom Renderer examples. This will be updated as we refine the feature and add more options.
2.04k stars 411 forks source link

Ported LWRP RenderPass examples #11

Closed hybridherbst closed 4 years ago

hybridherbst commented 4 years ago

The examples here are pretty great and I was always wondering why they're not also in this repo.

Since 7.2.0 is out now I thought it would be a nice opportunity to port them over as WIP samples, so here they are. I ported them to 2019.3 / URP 7.2.0 and adjusted them for this repo (e.g. automatically loading correct SRP profile on scene load).

20200212-010852_Unity 20200212-010909_Unity 20200212-011010_Unity

They'll need a bit folder structure cleanup, so I added them to the "WIP" section for now.

hybridherbst commented 4 years ago

@phi-lira do you think you or someone else could over this to merge it in, or tell me what changes are required?

andybak commented 4 years ago

Could we at least have a comment from someone at Unity that's either:

  1. Yes - we just need to find the time. It's on our to do list
  2. Sorry - we'll probably never find the time as we're ultra busy
  3. We don't think this should be merged.
  4. We might merge but it needs some tweaks

In the absence of 1 to 4 we can only conclude

  1. We never look at pull requests

which is a bit disheartening!

phi-lira commented 4 years ago

Oh sorry about this. I guess we forgot to review it as we were not added to PR originally. I just added @Verasl but he is out of office now, I'm putting a note to have a chat with him when he's back.

hybridherbst commented 4 years ago

Bump! @phi-lira @Verasl

phi-lira commented 4 years ago

Changed this to working branch in our repo. Will take it from there.

andybak commented 4 years ago

Apologies if I've overlooked them but there's no mention of the new examples in the readme is there?

I can see that being the crucial entrypoint for someone trying to figure out how to do x in URP.

phi-lira commented 4 years ago

I'll have a follow up PR to change the examples, then I'll add wiki pages / changes to README.