search

UniversalDependencies / UD_English-EWT

English data
Creative Commons Attribution Share Alike 4.0 International
201 stars 43 forks source link

Clause as predicate/:outer subjects #356

Closed nschneid closed 2 years ago

nschneid commented 2 years ago

310 - implemented with the help of not-to-release/{be-ccomp.sh,outer-subj.sh}

nschneid commented 2 years ago

@amir-zeldes Would you mind doing a spot check before I merge, since this is such a big change?

amir-zeldes commented 2 years ago

sure, will take a look

nschneid commented 2 years ago

@amir-zeldes Notice any issues? I want to merge this so I can make further changes

amir-zeldes commented 2 years ago

Yes, I made several comments above, please take a look.

nschneid commented 2 years ago

Where? On this PR? The clefts etc. are separate.

amir-zeldes commented 2 years ago

Yes, right here - I'm seeing them as a 'review'. Not sure maybe we're using different URLs to look at this PR? I'm looking at:

https://github.com/UniversalDependencies/UD_English-EWT/pull/356 and I can see them right away. Maybe 'view changes' is better?

https://github.com/UniversalDependencies/UD_English-EWT/pull/356/files/de7c0df547c7707910cf1216d4aa8601c29f859e

nschneid commented 2 years ago

Hmm. Maybe you started a review but haven't submitted it so I can't see it? https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/reviewing-proposed-changes-in-a-pull-request#submitting-your-review

amir-zeldes commented 2 years ago

OK, sorry, I think I submitted it now!

nschneid commented 2 years ago

Query for bad free relatives with matrix copular clause: http://universal.grew.fr/?custom=633b062a632dc