search

UniversalDependencies / UD_English-EWT

English data
Creative Commons Attribution Share Alike 4.0 International
197 stars 41 forks source link

Fix punct edeps #456

Closed martinpopel closed 8 months ago

martinpopel commented 8 months ago

fixes #453 This is an alternative to #454 (feel free to merge #454 instead of this PR, once it is synced with the current dev; ideally compare this and #454 if there is any diff).

martinpopel commented 8 months ago

I just found out this PR creates three [L2 Enhanced unconnected-egraph] validation errors. I plan to improve the ud.FixPunct code to prevent this, but perhaps not today.

AngledLuffa commented 8 months ago

Manually fix?

I haven't run the validation on my branch (although the branch is there in the repo for anyone to validate and/or edit)

martinpopel commented 8 months ago

This PR is now ready for merge. It passes the validation (except for one warning that was there before my edits).

nschneid commented 8 months ago

Thanks!