search

UniversalGRAMM / UGRAMM

Universal GRAph Minor Mapper (UGRAMM)
https://universalgramm.github.io/
Other
2 stars 0 forks source link

Feedback on visualizer and Fanout out not properly being visualized #8

Closed HamasWaqar closed 1 month ago

HamasWaqar commented 1 month ago

Hey @ombhilare999 ,

Two things. Firstly, the GRAMM visualizer does not seem to correctly depict fan out in the output dot files. For instance, take the following kernel example seen in the image below. In this case, load 8 has a fanout signal.

image

This fanout can be properly be seen in the textile output but can not be seen in the out dot file visualizer. Could you look into why this is occurring:

image

image

Instruction to reproduce this error: Branch: addingConstant Command: ./run_gramm.sh Kernels_Modified/Conv_Balance/conv_nounroll_Balance_Tester_Fanout.dot 8 8 RIKEN_with_pins > ./logs/log.txt

Secondly, I wanted to also give you some feedback on the visualizer in general. Overall, the visualizer is great and extremely helpful in debugging the mapping. However, there are few things that I believe need to be improved on. These recommendation is listed below.

  1. Could we use light colour on the background of the nodes. Some of the current nodes have dark background that it is hard to read the label. For instance, the input pins node were set to have a dark blue background, but this just made it impossible to read the label without squinting. I had to change it to a light green background just to read the label
  2. Could we bold the text of the label and thicken the arrows and node border in both the positioned and unpositioned output dot files
  3. Could we add constant in the positioned output dot file. This would be extremely helpful to visualize the mapping of the constant.
ombhilare999 commented 1 month ago

Hi @HamasWaqar ,

I have fixed the fanout visualization issue.

image

image

As you see the fanout is correctly shown in the benchmark you have mentioned.

  1. Could we use light colour on the background of the nodes. Some of the current nodes have dark background that it is hard to read the label. For instance, the input pins node were set to have a dark blue background, but this just made it impossible to read the label without squinting. I had to change it to a light green background just to read the label
    • [Done] Change darker colors to the lighter one
  2. Could we bold the text of the label and thicken the arrows and node border in both the positioned and unpositioned output dot files
    • [Done]
  3. Could we add constant in the positioned output dot file. This would be extremely helpful to visualize the mapping of the constant.
    • [TO-DO] I wanted to discuss few things related to this in tomorrow's meeting, let's add this feature afterwards.
    • The support for constant in the positioned_graph has been added in this commit 26bf0596838f3e4eaaa806516e34f096267fad38 Let me know if you find any more bugs in the visualize functions.
ombhilare999 commented 1 month ago

Refer commit https://github.com/ombhilare999/GRAMM/commit/80a88f1d35a264eab27537591b55162a844965a8