UniversalGRAMM / UGRAMM

Universal GRAph Minor Mapper (UGRAMM)
https://universalgramm.github.io/
Other
2 stars 0 forks source link

Adding constant branch to master #9

Closed HamasWaqar closed 1 month ago

HamasWaqar commented 1 month ago

@ombhilare999, I am going to merge the addingConstant branch to the master. Could you approve of the changes in a reply before I move on.

This branch contains the following changes:

  1. Reinstanting constant in GRAMM
  2. Adding pins in GRAMM
  3. Helper scripts to help modify the application benchmarks

Hamas

ombhilare999 commented 1 month ago

Also @HamasWaqar , can you please add some brief documentation about how you added these two features (primarily the 2nd point):

1. Reinstanting constant in GRAMM
2. Adding pins in GRAMM
HamasWaqar commented 1 month ago

Also @HamasWaqar , can you please add some brief documentation about how you added these two features (primarily the 2nd point):

1. Reinstanting constant in GRAMM
2. Adding pins in GRAMM

Where do you want to add the documentation @ombhilare999

ombhilare999 commented 1 month ago

Hi @HamasWaqar , Some details about the features in the original message of PR will be helpful, please refer #2 #5

ombhilare999 commented 1 month ago

Also @HamasWaqar , if we are not using these functions, can we remove them before pushing to Master branch? https://github.com/ombhilare999/GRAMM/blob/6473300eff4f13894dfd02a8a50387975880e3c7/src/GRAMM.cpp#L34-L52

HamasWaqar commented 1 month ago

Also @HamasWaqar , if we are not using these functions, can we remove them before pushing to Master branch?

https://github.com/ombhilare999/GRAMM/blob/6473300eff4f13894dfd02a8a50387975880e3c7/src/GRAMM.cpp#L34-L52

I'll remove those functions