search

UofTMADLab / reach

A VR format for Twine
0 stars 0 forks source link

semicolons break text panels #52

Closed titaniumbones closed 4 years ago

titaniumbones commented 4 years ago

I'm not sure what's causing this, but if a semi-colon is included in a text panel in any position except the final character, the ntext panel will not render. The <tw-passagedata> element will still be created, but the rendering breaks somewhere without throwing an error. It's a bit hard for me to follow the chain, but I guess the error seems to occur in reach_text_panel.js when the background a-entity is created. I've tried pre-escaping the semicolong but that does not seem to help.

I'm not sure if there are perhaps also other entit-related gotchas.

samesimilar commented 4 years ago

Good catch - this was happening because of how the text was being assigned to the 3d object (using a css-like string which doesn't allow escape of semi-colons). This should be resolved in the latest commit and you can use semi-colons without hesitation. Please test.

titaniumbones commented 4 years ago

Finally tested this (have mostly switched to HTML passages and lost track of this). Now works, losing the issue.