UofUEpiBio / epiworldpy

https://uofuepibio.github.io/epiworldpy/
Other
1 stars 1 forks source link

Implement `get_hist_total` #18

Closed IsaccBarker closed 4 months ago

IsaccBarker commented 4 months ago

Fixes #15.


Added database tests by way of running a SEIR model and checking the lengths of the returned Numpy arrays dates, states, and counts to make sure they are of the correct length.


We expose geting the database from models with the getDb function.

We expose getting historical totals from databases with the getHistTotal function, which returns a dictionary of dates, states, and data (counts).

We expose getting the name of a model with the getName function.


Added a graph to the example in the qmd file. This pulls a generated graph from the README_files directory.

IsaccBarker commented 4 months ago

For reference, a generated graph. I made the y-axis logarithmic because I felt it visualized things better, but if this is unacceptable let me know. Also, the y-axis is labeled count. I assume there's a better label, but I'm unsure as to what it might be. image

gvegayon commented 4 months ago

Awesome job! Notice there's a lot of files that should not be included, namely, all the HTML stuff it is only used for pre-view the HTML version of the README.md file.

gvegayon commented 4 months ago

For reference, a generated graph. I made the y-axis logarithmic because I felt it visualized things better, but if this is unacceptable let me know. Also, the y-axis is labeled count. I assume there's a better label, but I'm unsure as to what it might be. image

Looks great! I would keep the "regular scale" and perhaps remove the susceptible cases only.

IsaccBarker commented 4 months ago

Awesome job! Notice there's a lot of files that should not be included, namely, all the HTML stuff it is only used for pre-view the HTML version of the README.md file.

Sorry about that; I generated an HTML report and must have forgotten to remove that data. Will remove.

IsaccBarker commented 4 months ago

Graph sample image

gvegayon commented 4 months ago

The Codacity statement seems to be a common issue: https://github.com/fossasia/query-server/issues/332.