UofUEpiBio / epiworldpy

https://uofuepibio.github.io/epiworldpy/
Other
1 stars 1 forks source link

Wrap the Rest of the Models #31

Closed IsaccBarker closed 3 months ago

IsaccBarker commented 3 months ago

Wrapped the rest of the models. I would have done this in a loop or something instead of having all these separate files, but I wanted to keep it simple before I found out if it would work or not (and not through a duplicate symbol error).

IsaccBarker commented 3 months ago

The issue is an issue with macro expansion and tokenization. Fixing now and writing tests, should be done soon. After that it's run_multiple_get_results for #26.

IsaccBarker commented 3 months ago

A things to consider. I'm not doing any data validation right now to see if the model is returning the right value (e.g. to check if there was some wires crossed in the binding process and an incorrect model was being run), for the reason below:

tests/test_model.py

# TODO: Decide the right way to validate data; how often is the underlying C++
# simulation code changed in a way that will change outputs here? What's the
# tradeoff?

There's also the blank test cases for the non-connected models (e.g. test_seir_simple, test_sir_simple, test_sird_simple) because the API to give a model some agents (e.g. agents_from_adjlist, agents_from_edgelist) haven't undergone binding just yet (see issue #32).

Another thing: I have no idea how I might test test_diffnet_simple, because the parameters are a bit opaque. Many of the model parameters aren't documented, and as far as I can see there aren't any examples:

image

IsaccBarker commented 3 months ago

@gvegayon Can we consider merging this to allow easier development of #33 and #26?

gvegayon commented 3 months ago

So we have the sphinx site included. We should add a GHA to build it. Here is an example of one that also renders quarto files and publishes it using GitHub pages: https://github.com/CDCgov/multisignal-epi-inference/blob/ef872383de148664fad4cbecad96703c2829c5a1/.github/workflows/website.yaml

IsaccBarker commented 3 months ago

Can you ignore memory leak notifications in Codacy for database.cpp? It's complaining because we're only delete'ing new'd memory inside a closure that Codacy can't seem to wrap it's mind around.

IsaccBarker commented 3 months ago

So we have the sphinx site included. We should add a GHA to build it. Here is an example of one that also renders quarto files and publishes it using GitHub pages: https://github.com/CDCgov/multisignal-epi-inference/blob/ef872383de148664fad4cbecad96703c2829c5a1/.github/workflows/website.yaml

Just realized that this should have been it's own commit/PR... Don't know how that got past me, apologies. If you like, I can shuffle things around so that they're separate in the history, but for now I'm assuming we're moving forward like this, so the GHA PR for the Sphinx docs will branch off this.