search

Upliner / CharMorph

Other
305 stars 14 forks source link

Blender 3.3.1 LTS Random Crash (Windows 10) #13

Open GeneralProtectionFault opened 1 year ago

GeneralProtectionFault commented 1 year ago

While using morphs (in this particular case, MB-Lab Male), Blender crashes. This seemed to be preceeded by the sliders having no affect on the model.

Attached crash dump: Blender3.3.1_CharMorph.crash.txt

Upliner commented 1 year ago

I see that undo code crashes. I've added support for another undo mode. Can you please try latest master and set undo mode to "Simple" in preferences?

GeneralProtectionFault commented 1 year ago

Looks like the same results, at least on my existing file. However, knowing it's the undo, I can confirm steps to reproduce. It looks like the first undo works on the model, but the slider remains unmoved. Blender itself doesn't crash at this point. Then if you start messing w/ sliders and/or try to use undo more, that's when when Blender, itself, crashes.

Here is the dump from the 2nd attempt, if it's of any use: CharMorphCrash_Simple.txt

I did not, however, try creating a new blend file with the changes, so if that is necessary, I can try that. Since there isn't an actual release with the code changes, though, I'd need to have the models available. If that's something like simply overwriting the contents of the existing release .zip with the latest code, I can try that.

Upliner commented 1 year ago

OK it seems I've managed to fix it. If the latest master works OK for you, I'll bump version to 0.3.2 and upload it as new release.

GeneralProtectionFault commented 1 year ago

Something is still off a bit... So the actual Blender crashing seems to be fixed, but the behavior of the addon is weird. Ctrl + Z does the same thing on the first attempt--meaning it undoes the model change, but the slider stays put.
If I press Ctrl + Z again, it seems to zero out the slider and I see values on the other sliders change.

If I continue to mess with the slider & undo again, I get some absurd output shown here: image

Again, this is using the same file as I was originally, and the Simple mode you specified, but it looks like the behavior doesn't change between Simple & Advanced, if that was intended. I don't see anything in the Blender system console while doing any of this.

Upliner commented 1 year ago

OK, one more fix, please try now

GeneralProtectionFault commented 1 year ago

It's definitely much better! Going through and the undo & slider behavior is just how I'd expect it to be. Emboldened, I started trying to break it LOL. I'm not sure if the Advanced/Simple mode was meant as a temporary fix, but it's still there. I tried it back on Advanced, which seemed to work, but after messing with several sliders and switching between morphs, I did get Blender to perpetually hang. No output from that.

However, putting it back to Simple, I did the same thing...modified sliders, undo this & that, switch morphs, repeat...and it was working pretty well, but I finally did get it to crash. Not sure of the exact conditions, but here is the crash dump:

CharMorph.MostlyWorking.Crash.txt

But good job either way, the case has been pushed much closer to the edge, definitely worth including at this point :).

Upliner commented 1 year ago

Hmm even no stack trace... OK I'll keep trying to reproduce it but it may take longer...