310 make collect locations dynamic in footer

VOKO-Utrecht / voko

Administration and automation for VOKO

4 stars 8 forks source link

310 make collect locations dynamic in footer #320

Closed bveldkamp closed 12 months ago

bveldkamp commented 12 months ago

Some notes:

I'm not sure if this is the best place for context_processors.py
The addresses will now show the city, rather than the neighborhood (i.e. Vogelbuurt), if we want those too, they should probably be added to the address's description
Depending on the length of the description, addresses may not be properly aligned

mgvd commented 12 months ago

Thank you.

mgvd commented 12 months ago

The neighborhood is stored in the description field, the name field is used for the location name (i.e. Averechts, Krachtstation). Can you update the template to show both?

bveldkamp commented 12 months ago

Okay, I totally missed the name field, and will change it. Is city still necessary then, there aren't any plans to expand outside Utrecht, right?

mgvd commented 12 months ago

Agreed, City is not necessary, so we can leave that out.

Op wo 11 okt 2023 om 16:38 schreef Berend Veldkamp @.***

:

Okay, I totally missed the name field, and will change it. Is city still necessary then, there aren't any plans to expand outside Utrecht, right?

— Reply to this email directly, view it on GitHub https://github.com/VOKO-Utrecht/voko/pull/320#issuecomment-1757836258, or unsubscribe https://github.com/notifications/unsubscribe-auth/AARKEMTOEORONPD4F3SQNM3X62VPTANCNFSM6AAAAAA5YRD3CU . You are receiving this because you modified the open/close state.Message ID: @.***>

bveldkamp commented 11 months ago

Fixed it. The address should now be exactly the same as it is on production