Emulator should check if ROM exists

VUEngine / VUEngine-Studio

Full-featured Nintendo Virtual Boy game development application.

https://www.vuengine.dev

MIT License

33 stars 4 forks source link

Emulator should check if ROM exists #60

Open KR155E opened 1 year ago

KR155E commented 1 year ago

When loading the emulator widget, check if the ROM file (still) exists. If not, mark file as deleted? Close emulator? Show error message? TBD

jorgeche commented 1 year ago

I'm not sure what "loading the emulator widget" entails. I see the widget at the right side of the window all the time. At the moment, when I hit the Play button, if there is no ROM, the building process start, which is the expected behavior.

KR155E commented 1 year ago

I am referring to the widget that is the actual emulator itself. Not the sidebar widget. Here's an example for a scenario that is currently not optimally handled:

You start the game via the run command (or use VES to play any other Virtual Boy ROM file)
You quit VES
You delete the ROM you previously loaded in VES, for example if you tested a random ROM and remove it after the test
You start VES again
It will load the previously opened tabs, including the one holding the emulator for the deleted ROM
No ROM can be found and an empty string is fed to the emulator, whose window just stays black

jorgeche commented 1 year ago

I would simply close the tab. When I open a ROM, I don't think of it as a file, but as a running game; and a running game is an ephemeral thing. Not only that, I would close the emulator's tab even if the ROM exists because the it uses quite a bit of CPU and having it running automatically in a tab that may not be visible if I had tons of others before closing VES, it would be wasting resources until I launch the emulator again or find about it running already.