search

ValeMTo / ingsw2022-AM38

1 stars 0 forks source link

Please add Sonarqube action #10

Closed PiroX4256 closed 2 years ago

PiroX4256 commented 2 years ago

Guide

ingconti commented 2 years ago

added?

PiroX4256 commented 2 years ago

They added it 12 minutes ago, let's wait for the pipeline scheduled for 8pm.

cerutigiacomo commented 2 years ago

Change the pom.xml in this one. ` <?xml version="1.0" encoding="UTF-8"?>

<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">

4.0.0 it.polimi.ingsw AM38 1.0-SNAPSHOT AM38 UTF-8 17 17 junit junit RELEASE test org.junit.jupiter junit-jupiter 5.8.2 test org.sonarsource.scanner.maven sonar-maven-plugin 3.7.0.1746 org.jacoco jacoco-maven-plugin 0.8.7 default-prepare-agent prepare-agent jacoco-report test report maven-clean-plugin 3.1.0 maven-resources-plugin 3.0.2 maven-compiler-plugin 3.8.0 maven-surefire-plugin 2.22.1 maven-jar-plugin 3.0.2 maven-install-plugin 2.5.2 maven-deploy-plugin 2.8.2 maven-site-plugin 3.7.1 maven-project-info-reports-plugin 3.0.0

` You forgot to put the jacoco plugin out of the section.

NickF19 commented 2 years ago

We have updated the Pom file using your recommendations. Now the Sonar Plugin should be correctly configured. Let us know if more changes are required. Good afternoon.

PiroX4256 commented 2 years ago

Tests are not running, since testng conflicts with junit. Please remove testng from your pom

NickF19 commented 2 years ago

We have removed testng and changed some missing parameters on the YML file. Now everything should work smoothly. Goodmorning