Vanalite
commented
5 months ago Hi Bliss,
Thank you for your feedback. I am aware of many of your suggestions for the improvement of the product. I do believe if we have a full cycle of development, any product should take all aspects into account and provide more details in testing, structuring, and security enhancement. However, this challenge is only one week time limited and the amount of tasks already exceeds this limitation.
I do think this challenge should be shorter with lessen stacks to tackle or prolonging the time limit, although it would be tough for the candidate to spend more than a week on a coding challenge.
I would love to have a further discussion if this can ease your mind that those feedback points can be resolved from my side with a fully displayed solution.
Thank you for your time. Best regards, Nghia Doan
Hi Doan HUU Nghia.

Thank you for your interest and for spending time to work on this Code Challenge assignment. My name is Bliss - Senior Software Engineering at Nimble.

I would like to provide you with some feedback on your submission so you may take it for further improvements in the future. No more submissions will be needed from your end.
On the layout management, you may want to devise a better plan to manage the consistency as the project could grow along the way. For instance: use extracted resource values for reusability and consistency e.g., dimens, colors; better typography management; or even leverage the theming attributes over creating Styles arbitrary.
Having a CI system to run unit tests (and even better, also UI Test) is critical for a quality application.
Committing secrets to the repository is unsafe and is not encouraged.
I hope this was helpful to you.
Best regards,
 Bliss Pisit.