Vanilagy / mp4-muxer

MP4 multiplexer in pure TypeScript with support for WebCodecs API, video & audio.
https://vanilagy.github.io/mp4-muxer/demo
MIT License
419 stars 32 forks source link

Export MuxerOptions #42

Closed joghyrt closed 6 months ago

joghyrt commented 6 months ago

Hello!

Could you export MuxerOptions?

now:

export { Muxer, ArrayBufferTarget, StreamTarget, FileSystemWritableFileStreamTarget };

then:

export { Muxer, ArrayBufferTarget, StreamTarget, FileSystemWritableFileStreamTarget, MuxerOptions };

It would reduce code lines significantly in my project.

Thank you!

Vanilagy commented 6 months ago

Good point. In the meantime, you should be able to do

type Constructor = new (...args: any[]) => any;

type FirstConstructorParameter<T extends Constructor> = 
    ConstructorParameters<T> extends [infer P, ...any[]] ? P : never;

type MuxerOptions = FirstConstructorParameter<typeof Muxer>;
Vanilagy commented 6 months ago

v4.1.0 now exports the MuxerOptions type.

joghyrt commented 6 months ago

@Vanilagy thank you so much! It was super fast!