Vek17 / TabletopTweaks-Base

Tabletop Tweaks is a mod that seeks to adjust the cRPG rules to more closely follow the tabletop ruleset. Additionally it adds content missing from the base game.
MIT License
160 stars 73 forks source link

Changes to game not fully disabling. #503

Open Biothurge opened 2 years ago

Biothurge commented 2 years ago

Certain features of this mod, particularly those related to classes, don't appear to fully disable when the option is turned off in the mod manager menu. The problems it's causing me are rather minor, and I've managed to work around them for the most part, but it has implications for compatibility with other mods. I don't know how concerned you are about that, but I thought I was worth mentioning.

Details: I'm an experienced modder, but I don't know C# and I'm not experienced at using the tools used to mod this game. However, using the game's blueprints and some of the information at https://github.com/OwlcatOpenSource/WrathModificationTemplate I have been able to create mods for my own use by just modifying the game's blueprints or adding my own along with calls for my own blueprints in modified game blueprints. I've been using this to experiment with some homebrew class concepts (and just for fun, because I like fun). It works by modifying a blueprint and putting it in a 'Blueprints' folder in the bundles folder.

For example, I like insects and was rather disappointed in the way the swarm that walks was implemented (I don't do evil characters, as a rule.) So I 'borrowed' some of the art assets used for swarm that walks and for other spells and abilities in the game and created a custom insect themed alchemist class to replace the Incense Synthesizer archetype.

When I first installed your mod, I found that it interfered with my own simpler one, but that I could get around that by simply disabling the table top tweaks features that related to alchemists. I also successfully modified a couple other archetypes, feats and so forth. So long as any related tabletop tweaks features were disabled, my own blueprints would load. If they were enabled, my own blueprints wouldn't load and it would use the default blueprints with tabletop tweaks changes instead. Interestingly, I found that I could actually switch back and forth between the two without any noticeable problems.

However, I recently tried to modify an oracle archetype to use the druid spell list instead of the oracle spell list (the divine herbalist, to be specific). It didn't work. After some trouble shooting, I found that it worked just fine if I turned off tabletop tweaks base. To make a long story slightly shorter, I disabled every feature in Base but left the mod enabled, and my altered blueprint still wouldn't load into the game unless base was turned off (set not to load in the game at all as opposed to having the features disabled in base's menu). This affects ALL oracle archetypes and the oracle base class.

So far I've identified druid, hunter, bard, the bard talent list, and hunter as having the same issue.

Vek17 commented 2 years ago

The only things present would be some core fixes that everything depends on that don't modify classes. I'd need logs to know what is failing and if anything can be done.

On Sun, Oct 9, 2022, 4:52 AM Biothurge @.***> wrote:

Certain features of this mod, particularly those related to classes, don't appear to fully disable when the option is turned off in the mod manager menu. The problems it's causing me are rather minor, and I've managed to work around them for the most part, but it has implications for compatibility with other mods. I don't know how concerned you are about that, but I thought I was worth mentioning.

Details: I'm an experienced modder, but I don't know C# and I'm not experienced at using the tools used to mod this game. However, using the game's blueprints and some of the information at https://github.com/OwlcatOpenSource/WrathModificationTemplate I have been able to create mods for my own use by just modifying the game's blueprints or adding my own along with calls for my own blueprints in modified game blueprints. I've been using this to experiment with some homebrew class concepts (and just for fun, because I like fun). It works by modifying a blueprint and putting it in a 'Blueprints' folder in the bundles folder.

For example, I like insects and was rather disappointed in the way the swarm that walks was implemented (I don't do evil characters, as a rule.) So I 'borrowed' some of the art assets used for swarm that walks and for other spells and abilities in the game and created a custom insect themed alchemist class to replace the Incense Synthesizer archetype.

When I first installed your mod, I found that it interfered with my own simpler one, but that I could get around that by simply disabling the table top tweaks features that related to alchemists. I also successfully modified a couple other archetypes, feats and so forth. So long as any related tabletop tweaks features were disabled, my own blueprints would load. If they were enabled, my own blueprints wouldn't load and it would use the default blueprints with tabletop tweaks changes instead. Interestingly, I found that I could actually switch back and forth between the two without any noticeable problems.

However, I recently tried to modify an oracle archetype to use the druid spell list instead of the oracle spell list (the divine herbalist, to be specific). It didn't work. After some trouble shooting, I found that it worked just fine if I turned off tabletop tweaks base. To make a long story slightly shorter, I disabled every feature in Base but left the mod enabled, and my altered blueprint still wouldn't load into the game unless base was turned off (set not to load in the game at all as opposed to having the features disabled in base's menu). This affects ALL oracle archetypes and the oracle base class.

So far I've identified druid, hunter, bard, the bard talent list, and hunter as having the same issue.

— Reply to this email directly, view it on GitHub https://github.com/Vek17/TabletopTweaks-Base/issues/503, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWSQPHXMRFWYRLZ6UY4L63WCKIU3ANCNFSM6AAAAAARAT7SFM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Biothurge commented 2 years ago

I'm pretty sure it's base, as I had core and reworks still enabled. Of course, you know more about it than I do. In any case, here are some logs.

I made a quick modification of oracle divine herbalist with more extensive changes than my original, created a new character with that archtype, then leveled them up once using toybox. Then I repeated as closely to the same actions, once with base turned completely off and once with all the options in base disabled but base turned on. GameLogFull_BaseOptionsEnabled.txt GameLogFull_BaseTurnedOff.txt GameLogFullPrev_BaseOptionsDisabled.txt Player_BaseOptionsDisabled.log Player_BaseOptionsEnabled.log Player_BaseTurnedOff.log

Fmk47 commented 2 years ago

Hi I am also seeing this issue.

Vek17 commented 2 years ago

Again I need logs and idealing theod you are breaking things with to identify anything.

On Wed, Oct 12, 2022, 12:09 AM Fmk47 @.***> wrote:

Hi I am also seeing this issue.

— Reply to this email directly, view it on GitHub https://github.com/Vek17/TabletopTweaks-Base/issues/503#issuecomment-1275596004, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWSQPGN2BUSBTVDGP2JP63WCZBXPANCNFSM6AAAAAARAT7SFM . You are receiving this because you commented.Message ID: @.***>