Vek17 / TabletopTweaks-Base

Tabletop Tweaks is a mod that seeks to adjust the cRPG rules to more closely follow the tabletop ruleset. Additionally it adds content missing from the base game.
MIT License
160 stars 73 forks source link

Bug/Request: Metamagic: Elemental Spell applies BEFORE Elemental Bloodline Arcana #581

Open CaptOcto opened 1 year ago

CaptOcto commented 1 year ago

Having both Elemental Bloodline Arcana active and Elemental Spell 50% damage results in all damage being inflicted being of the type of Elemental Bloodline Arcana completely superseding the applied Metamagic and making the Metamagic feat useless.

Is it possible to change/fix the order of operations so that all damage can be changed to Elemental Bloodline damage type and THEN Metamagic: Elemental Spell be applied (to be able to actually use the Metamagic as it was presumably intended).

To reproduce: Activate Elemental Bloodline Arcana, Elemental Spell Split Damage, Cast spell of 3rd element (in this case Melfs Acid Arrow) Observed: All damage inflicted is of the Elemental Bloodline Arcana type. Expected: Damage inflicted would be 50% Elemental Bloodline Arcana type and 50% Elemental Spell type.

Vek17 commented 1 year ago

The behavior in the upcoming patch (that will be shipped after the DLC patch today) is t hat elemental spell applies after. This allows half conversions with elemental bloodline.

CaptOcto commented 1 year ago

Oh man, that's so exciting! Guess I will be taking Cross Blooded Sorcerer as my next level up! Get ready for my 50% Acid, 50% Unearthly Cold Elemental Barrage Zippy Chain Lightnings Demons!

On Wed, Mar 8, 2023 at 12:34 AM Sean Petrie @.***> wrote:

The behavior in the upcoming patch (that will be shipped after the DLC patch today) is t hat elemental spell applies after. This allows half conversions with elemental bloodline.

— Reply to this email directly, view it on GitHub https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1458281740, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4S52J6AA46ZG6DHYW234S3W25BQ3ANCNFSM6AAAAAAVRZ5HAI . You are receiving this because you authored the thread.Message ID: @.***>

CaptOcto commented 1 year ago

Can I confirm when this update is going live? Cheers.

On Wed, Mar 8, 2023 at 11:45 AM Aram Madigan @.***> wrote:

Oh man, that's so exciting! Guess I will be taking Cross Blooded Sorcerer as my next level up! Get ready for my 50% Acid, 50% Unearthly Cold Elemental Barrage Zippy Chain Lightnings Demons!

On Wed, Mar 8, 2023 at 12:34 AM Sean Petrie @.***> wrote:

The behavior in the upcoming patch (that will be shipped after the DLC patch today) is t hat elemental spell applies after. This allows half conversions with elemental bloodline.

— Reply to this email directly, view it on GitHub https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1458281740, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4S52J6AA46ZG6DHYW234S3W25BQ3ANCNFSM6AAAAAAVRZ5HAI . You are receiving this because you authored the thread.Message ID: @.***>

Vek17 commented 1 year ago

This is live already

On Tue, Mar 7, 2023, 22:47 CaptOcto @.***> wrote:

Can I confirm when this update is going live? Cheers.

On Wed, Mar 8, 2023 at 11:45 AM Aram Madigan @.***> wrote:

Oh man, that's so exciting! Guess I will be taking Cross Blooded Sorcerer as my next level up! Get ready for my 50% Acid, 50% Unearthly Cold Elemental Barrage Zippy Chain Lightnings Demons!

On Wed, Mar 8, 2023 at 12:34 AM Sean Petrie @.***> wrote:

The behavior in the upcoming patch (that will be shipped after the DLC patch today) is t hat elemental spell applies after. This allows half conversions with elemental bloodline.

— Reply to this email directly, view it on GitHub < https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1458281740 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/A4S52J6AA46ZG6DHYW234S3W25BQ3ANCNFSM6AAAAAAVRZ5HAI

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1459463706, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWSQPHMMVJ7CITNCQJBPYLW3AFNJANCNFSM6AAAAAAVRZ5HAI . You are receiving this because you commented.Message ID: @.***>

CaptOcto commented 1 year ago

Then maybe not working as intended?

I updated via ModFinder, took a level of sorcerer (water + white), activated conversion and cast a spell which had been memorised with Elemental Spell (Acid) and only got ice damage.

On Wed, 8 Mar 2023, 2:48 pm Sean Petrie, @.***> wrote:

This is live already

On Tue, Mar 7, 2023, 22:47 CaptOcto @.***> wrote:

Can I confirm when this update is going live? Cheers.

On Wed, Mar 8, 2023 at 11:45 AM Aram Madigan @.***> wrote:

Oh man, that's so exciting! Guess I will be taking Cross Blooded Sorcerer as my next level up! Get ready for my 50% Acid, 50% Unearthly Cold Elemental Barrage Zippy Chain Lightnings Demons!

On Wed, Mar 8, 2023 at 12:34 AM Sean Petrie @.***> wrote:

The behavior in the upcoming patch (that will be shipped after the DLC patch today) is t hat elemental spell applies after. This allows half conversions with elemental bloodline.

— Reply to this email directly, view it on GitHub <

https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1458281740

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/A4S52J6AA46ZG6DHYW234S3W25BQ3ANCNFSM6AAAAAAVRZ5HAI

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1459463706 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AAWSQPHMMVJ7CITNCQJBPYLW3AFNJANCNFSM6AAAAAAVRZ5HAI

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1459465202, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4S52J4EXV6HXLNRWYUAPA3W3AFQPANCNFSM6AAAAAAVRZ5HAI . You are receiving this because you authored the thread.Message ID: @.***>

Vek17 commented 1 year ago

Are you casting split elemental or full elemental spells? Split elementals should work properly full conversions I have not tested though they should apply after in theory as well.

On Wed, Mar 8, 2023, 00:32 CaptOcto @.***> wrote:

Then maybe not working as intended?

I updated via ModFinder, took a level of sorcerer (water + white), activated conversion and cast a spell which had been memorised with Elemental Spell (Acid) and only got ice damage.

On Wed, 8 Mar 2023, 2:48 pm Sean Petrie, @.***> wrote:

This is live already

On Tue, Mar 7, 2023, 22:47 CaptOcto @.***> wrote:

Can I confirm when this update is going live? Cheers.

On Wed, Mar 8, 2023 at 11:45 AM Aram Madigan @.***> wrote:

Oh man, that's so exciting! Guess I will be taking Cross Blooded Sorcerer as my next level up! Get ready for my 50% Acid, 50% Unearthly Cold Elemental Barrage Zippy Chain Lightnings Demons!

On Wed, Mar 8, 2023 at 12:34 AM Sean Petrie @.***> wrote:

The behavior in the upcoming patch (that will be shipped after the DLC patch today) is t hat elemental spell applies after. This allows half conversions with elemental bloodline.

— Reply to this email directly, view it on GitHub <

https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1458281740

,

or unsubscribe <

https://github.com/notifications/unsubscribe-auth/A4S52J6AA46ZG6DHYW234S3W25BQ3ANCNFSM6AAAAAAVRZ5HAI

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub <

https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1459463706

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/AAWSQPHMMVJ7CITNCQJBPYLW3AFNJANCNFSM6AAAAAAVRZ5HAI

. You are receiving this because you commented.Message ID: @.***>

— Reply to this email directly, view it on GitHub < https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1459465202 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/A4S52J4EXV6HXLNRWYUAPA3W3AFQPANCNFSM6AAAAAAVRZ5HAI

. You are receiving this because you authored the thread.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/Vek17/TabletopTweaks-Base/issues/581#issuecomment-1459614034, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWSQPAGJRTUYZQDX7AQE7DW3ARXDANCNFSM6AAAAAAVRZ5HAI . You are receiving this because you commented.Message ID: @.***>