Multiple instances of Elemental Barrage proccing overwrite actual Spell Damage.

[CaptOcto]

Attach a Bug Report https://www.dropbox.com/s/6vuuf64zqfx3znd/b6tgqw1h.mew?dl=0 https://www.dropbox.com/s/bmyvo0lmu9kl9ri/Quick_6.zks?dl=0

Describe the bug Spell damage not being applied. Only Frozen Caress damage is applied. A little testing appears to suggest that the 2 instances of Elemental Barrage is overwriting the spell damage (due to previously applied elemental markers). If I cast a damage spell at a fresh target then the spell damage occurs as normal. Not sure if this is a Tabletop Tweaks bug or a Character Options+ bug but its possible it was introduced with the Frozen Caress fix? Am posting the same bug in Character Options+, if the source can be confirmed from either mod (or perhaps its a WotR bug) then please close as appropriate!

Did another little test casting:

• 1 full power Snowball = Yes Frozen Caress damage, Yes Elemental Barrage damage, No Spell damage
• Disabled Frozen Caress and cast again = Yes Frozen Caress damage, Yes Elemental Barrage damage, No Spell damage
• cast a 3rd Snowball = No Frozen Caress, Yes Spell damage, Unclear Elemental Barrage (creature died before Elemental Barrage could proc)

I guess Frozen Caress is preventing spell damage to occur when interacting with Elemental Barrage and/or Elemental Spell. Once it was deactivated for some reason it took an extra round to actually register the deactivation. It's also possibly the source of other lost damage I've observed with Chain Lightning (sometimes it would seem that Chain Lightning would only affect enemies once instead of twice (which it should due to Zippy Magic)).

To Reproduce

1. Setup: Elemental Spell, Zippy Magic, Spell Barrage, Ascendant Element, Witch/Winter Witch/CBS
2. Snowball
3. 1d4+3 damage applied, actual spell damage not applied at all.

Expected behavior Expect to see the 5d6+x damage appear somewhere in damage log (and enemies actually dying!).

Screenshots https://www.dropbox.com/s/mmocffob0xidp3a/202303181103089440.png?dl=0

Additional context Add any other context about the problem here.

[Vek17]

Elemental doesn't actually interact with spell damage so I don't see a way that it could prevent it from occuring. I am guessing this is some bug with Frozen Caress throwing an exception some how but I am not sure where that could be. I'll ping Wolfie about it but I doubt this is on the TTT side.

[CaptOcto]

Thanks for your fast reply I suspect you're right!

[Vek17]

Brief look at the logs and there may be an issue with TTT but I can't easily test. If there is this TTT-Core should fix that potential issue can you test and see. This is not a proper release atm, but it should not break anything. TabletopTweaks-Core.zip

[CaptOcto]

It also appears as per this screenshot that spell damage isn't being applied correctly. For Hellfire Ray it should be either:

• 25% acid + 25% cold + 50% unearthly cold = 100%
• 50% acid + 25% cold + 25% unearthly cold = 100%

Instead it appears to be:

• 25% acid +12.5% cold + 12.5% unearthly cold = 50%

There isn't any other damage instances coming out that I can providing another 50% damage anywhere. I'll test your fix now.

[Vek17]

Hellfire ray damage is always in groups of 2 (The fire damage and then the unholy damage), so there should be two damage instances each with 50% of the total damage. 25% 12.5% 12.5% would be correct for one of those damage instances

[CaptOcto]

In that case is the Elemental Barrage overwriting the Unholy damage as there wasn't any Unholy damage then. It's pretty weird, sometimes the Hellfire Ray seems to work correctly (thankfully it did that fight vs Titanic Rune Thanodemon final fight or I would have lost) and sometimes its just terrible damage (no Unholy damage is probably the culprit).

[CaptOcto]

Think I installed the ZIP you gave me okay but it's hard to tell (I dragged the zip folder to modfinder drag location). Tweaks Core now reads 0.5.12.

In the above screenshot can see that Frozen Caress is still overriding the spell damage.

[Vek17]

I don't see any damage being overriden here, this looks like an extra frozen Caress proc from zippy magic somehow. But the damage from the snowball looks like it is there lower? This is based on the fact that is damage is occuring on spell cast BEFORE the attack roll for snowball has occurred lower down.

[CaptOcto]

No the damage is:

• Zippy Magic x2
• Frozen Caress x2
• Elemental Barrage x2
• Elemental Barrage x2

No spell damage being applied.

[CaptOcto]

I assume the 2x Elemental Damage being applied to each enemy is due to Sonic marker from Aivu breath weapon + Frozen Caress (which does Acid and Cold damage).

[CaptOcto]

0.5.12 is the correct version with this experimental fix right? I don't need to do anything special to install it besides dragging it onto ModFinder?

[Vek17]

Breath weapon wouldn't add a marker, the only way to get two procs is to get them from the spell damage hitting to detonate the ones added by frozen Caress. So the spell damage HAS to be happening or the elemental barrage damage wouldn't be triggering. >.> not sure what is going on exactly but it doesn't make any sense for the spell damage to not happen because effects of the spell damage are there.

And yes that is the right version, it should be fixing a case where exceptions could occur when dealing with the Unearthly code damage that were in the log.

[CaptOcto]

I think Aivu's breath weapon is interacting with Elemental Barrage because I've seen Elemental Barrage proc in the reverse order: I MC casts an elemental spell and then Aivu breaths proccing the barrage.

[CaptOcto]

Here is Aivu proccing Elemental Barrage 2 times against every enemy due to previously applied acid and cold markers.

[Vek17]

It should proc marks, but it should never apply marks. Marks can be proced by anyone with any source of elemental damage, but are only applied by spells cast by the person with the mythic ability.

Okay I just pushed an update that modifies elemental barrage behavior internally, not sure if related but this will put you in the same place I am looking at.

https://github.com/Vek17/TabletopTweaks-Core/releases/latest https://github.com/Vek17/TabletopTweaks-Base/releases/latest https://github.com/Vek17/TabletopTweaks-Reworks/releases/latest

[CaptOcto]

Okay updated not seeing any improvement. I'm not seeing any Unholy damage being inflicted and it seems all my spells are doing 50% of their advertised damage possibly because of a (durability) tag that is being applied to spells. Is that just a weird buff that some/all enemies have?

[Vek17]

Durability is from unearly cold, it is used when thing are already halved to half them again.

On Sat, Mar 18, 2023, 01:08 CaptOcto @.***> wrote:

Okay updated not seeing any improvement. I'm not seeing any Unholy damage being inflicted and it seems all my spells are doing 50% of their advertised damage possibly because of a (durability) tag that is being applied to spells. Is that just a weird buff that some/all enemies have?

[image: 202303181559315065] https://user-images.githubusercontent.com/119921959/226088251-e55127c2-566a-4564-b656-f1ca757ac5de.png [image: 202303181604288831] https://user-images.githubusercontent.com/119921959/226088253-d1676985-ec6f-4aa1-8f95-fdff4278f4d2.png [image: 202303181605137064] https://user-images.githubusercontent.com/119921959/226088256-f2b84f10-e3f2-40ae-a912-72912b271247.png

— Reply to this email directly, view it on GitHub https://github.com/Vek17/TabletopTweaks-Base/issues/596#issuecomment-1474741355, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWSQPAIUZYVPMHO4FOTOR3W4VGOPANCNFSM6AAAAAAV7E5PTI . You are receiving this because you commented.Message ID: @.***>

[Vek17]

There would be no unholy because you are converting it I assume via a sorc bloodline. But there should be two damage instances per ray.

On Sat, Mar 18, 2023, 01:37 Sean Petrie @.***> wrote:

Durability is from unearly cold, it is used when thing are already halved to half them again.

On Sat, Mar 18, 2023, 01:08 CaptOcto @.***> wrote:

Okay updated not seeing any improvement. I'm not seeing any Unholy damage being inflicted and it seems all my spells are doing 50% of their advertised damage possibly because of a (durability) tag that is being applied to spells. Is that just a weird buff that some/all enemies have?

[image: 202303181559315065] https://user-images.githubusercontent.com/119921959/226088251-e55127c2-566a-4564-b656-f1ca757ac5de.png [image: 202303181604288831] https://user-images.githubusercontent.com/119921959/226088253-d1676985-ec6f-4aa1-8f95-fdff4278f4d2.png [image: 202303181605137064] https://user-images.githubusercontent.com/119921959/226088256-f2b84f10-e3f2-40ae-a912-72912b271247.png

— Reply to this email directly, view it on GitHub https://github.com/Vek17/TabletopTweaks-Base/issues/596#issuecomment-1474741355, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWSQPAIUZYVPMHO4FOTOR3W4VGOPANCNFSM6AAAAAAV7E5PTI . You are receiving this because you commented.Message ID: @.***>

[CaptOcto]

Only 1 damage instance per ray I've checked very carefully. Or at least, the character shot 6 Ray's (caster level 19, Zippy Magic) and there was only 6 damage instances.

[Vek17]

So this is not 4 elemental barrage procs and two hellfire procs from one ray? Because it looks exactly as I'd expect it to.

[CaptOcto]

Okay maybe I was wrong things seem to be working okay at the moment 🙃 🙂