Vertfromage / ManFight

Two classes Man and ManFight that together make a fun little text game
MIT License
7 stars 29 forks source link

Improve the game #1

Closed Vertfromage closed 4 years ago

Vertfromage commented 4 years ago

This is a simple text based java game I made. I thought it would be fun to let any other beginners who have been learning java contribute to it for Hacktoberfest... this will be my first year participating too.

Possible Improvements:

Vertfromage commented 4 years ago

Completed:

ItsLaro commented 4 years ago

I'd like to work on this!

Vertfromage commented 4 years ago

ItsLaro, you're welcome to join in.

saguins commented 4 years ago

wow. this sounds fun. I would like to add some new class, like magician guy. 🧙‍♂️

Vertfromage commented 4 years ago

Robert the Magician added to the Fight Club by saguins! Really fun code! Thanks saguins!

RefreshingChi commented 4 years ago

I think it would be interesting to add health to the man class. There should be ways to increase health at random, when you have a successful attack. Also if your health is over 50% your attack would be stronger. Any thoughts on adding something like this. I would like to do ti

Vertfromage commented 4 years ago

RefreshingChi, sounds interesting, how would you make health work with the injury of and amusing comments related to various body parts? Would each body part have it's own health or would injuries happen in relation to the health level, or randomly? Feel free to give it a go!

Vertfromage commented 4 years ago

SinSentido added a characterCreation class, Thanks SinSentido.

wrongsyntax commented 4 years ago

What sort of documentation is needed for this?

Dovacody commented 4 years ago

If it's okay, I Was wondering if I could add comments about what's happening to better document the code, and add todos so others can add documentation that I leave out. Thank you !

RefreshingChi commented 4 years ago

@Vertfromage I am thinking the overall character will start off with health of 100. If you are attacked with a punch you lose 10 health points, kick lose 20 health points, headbutt is 30 points and if the roar randomNumber equals 0 your health can increase 10.

If you get your health to 125 it would regenerate one of your limbs(arm, leg) and your health would go to 75.

What you think of this

Vertfromage commented 4 years ago

wrongsyntax the documentation that could be added would be easy stuff like adding inline comments telling what methods do to make it easier for beginners to contribute. I added a quick contributing.md, but it could be improved by someone who's managed an open source project before and knows what should be said in a contributing.md

Dovacody has the right idea, that's exactly what I was thinking of.

I'm a beginner myself I opened up this project for contributions because I didn't find an easy enough java project to contribute to that wasn't just asking me to do code puzzles. I figured it would be fun, but I don't have much experience with github, so just dealing with merge conflicts is a bit of a learning experience for me. :)

Vertfromage commented 4 years ago

RefreshingChi sounds great, make sure you keep the fun dialogue, that's my favorite part, it reminds me of monty python. :)

JessieVela commented 4 years ago

Saw my PR was merged :) I automated the bad guy to move on his own. Hope people keep the improvements going.