search

Vipeax / MSI-LED-Tool

MSI LED Tool, an alternative for the default MSI tooling
MIT License
112 stars 17 forks source link

Increase CurrentThread.Join delay when no animation used #58

Closed Cubox closed 6 years ago

Cubox commented 6 years ago

Updating the LEDs is CPU intensive. When no animation is used, there is no need to update them so often. There should be a check here https://github.com/Vipeax/MSI-LED-Tool/blob/master/MSI%20LED%20Tool/Program.cs#L440 to increase this delay if the animation selected is NoAnimation

This would fix high CPU usage on some cases, while keeping users able to use animations

Vipeax commented 6 years ago

There is this thing called pull requests, right? :blush: I added a sleep elsewhere that should solve this in a better way.

Cubox commented 6 years ago

Thanks. I did not make a pull request because I did not know how to make those changes in a way that was clean/not a hack.

Cheers!