search

Virtuoel / Pehkui

Fabric/Forge/NeoForge/Quilt mod that allows for changing the size of any entity.
MIT License
91 stars 36 forks source link

[Performance Problems] Pehkui #375

Open Virtuoel opened 1 year ago

Virtuoel commented 1 year ago

Report performance issues you have with Pehkui here.

It is highly recommended to add a profiling report in your comment. You can create one by using the Spark mod and its profiler commands. For more info, check these links: https://spark.lucko.me/docs/Command-Usage https://modrinth.com/mod/spark https://www.curseforge.com/minecraft/mc-mods/spark

If your performance issue is specifically when Pehkui is used with another mod, add a comment to the corresponding issue from this list. If the mod has no issue yet, create a new issue and I'll add it to the list:

embeddedt commented 1 year ago

Here is a Spark profiler report (not by me) showing entity tick times being greatly exacerbated by Pehkui. As you can see from the bookmarks, the majority of the time appears to be spent by the mixin that modifies bounding boxes retrieving the scale using ScaleUtils.

https://spark.lucko.me/pLFykk8HZU?hl=483,332

Virtuoel commented 1 year ago

Looking through that profile, it shows 99% of the time coming from ItemEntity collision checking, which to me sounds like some contraption is overflowing way too many items onto the ground.

embeddedt commented 1 year ago

This is true, but in any case Pehkui is clearly adding enough overhead to that to be visible in the profiler.

JosTheDude commented 11 months ago

This is months past the original post of this issue, but Pekhui is the biggest performance hit on my server with almost 4% of the total 8% of the thread that is being taken up being done by grabbing scale data; couldn't this be done async?

image

https://spark.lucko.me/9lwL919s2Z

1356RYAN commented 10 months ago

Im also having similar things happening image https://spark.lucko.me/wv23LsFXCR

Freyr-VM commented 7 months ago

I'm having hella lag, it seems to be pehkui but im particulary new to this so i could be wrong image https://spark.lucko.me/eC6NVNsq1h

souldbminersmwc commented 5 months ago

Same

VerdantVerger commented 4 months ago

Same, working with bewitchment and Improved mobs 1 20 1 fabric imaаge

miyoshikai commented 3 months ago

Only during the Rain and Thunder weather, Pehkui's server thread usage is very high and lags the server. On any other weather, clear, rain, there is no lag at all. https://spark.lucko.me/xRuK4qFLAn

Deceasedcraft modpack

Here is a spark link for when it is not rain and thunder https://spark.lucko.me/gWiGETQvUL

ISSUE SOLVED: Foxes were the issue smh https://bugs.mojang.com/browse/MC-179916