Virtuoel / Pehkui

Fabric/Forge/NeoForge/Quilt mod that allows for changing the size of any entity.
MIT License
87 stars 34 forks source link

[Bug]: Crash when opening create world screen #428

Closed Jamalam360 closed 11 months ago

Jamalam360 commented 11 months ago

Minecraft version(s)

1.20.1

Minecraft version details

No response

Mod loader

Quilt

Mod loader version

0.19.2

Fabric API version

No response

In what kind of world or server did the problem occur?

Other (specify in "What went wrong?" section)

What went wrong? (Crash logs don't go here)

As in title

Full list of installed mods and their version numbers

Please see the mod table in the logs

Did the problem cause the game to crash?

Yes. (paste crash report below)

Full crash report contents (if you experienced a crash)

https://mclo.gs/0WcLcNT

Jamalam360 commented 11 months ago

Sorry for not following your issue template I am in a rush :smile:

Virtuoel commented 11 months ago

Appears to be caused by ValkyrienSkies redirecting a call that I @ModifyArg, specifically with this, which results in the vector object from the redirect being added to the arg list.

Ideally this PR that would fix this in Mixin could be merged. Alternatively, VS could probably do a @ModifyArg instead of redirecting.

Virtuoel commented 11 months ago

Should now be resolved with a workaround on Pehkui's end as of Pehkui 3.7.7.