search

Virtuoel / Pehkui

Fabric/Forge/NeoForge/Quilt mod that allows for changing the size of any entity.
MIT License
91 stars 34 forks source link

[Bug]: Offset bug with First-Person Model #439

Open silvux opened 1 year ago

silvux commented 1 year ago

Minecraft version(s)

1.19.2

Minecraft version details

No response

Mod loader

Forge

Mod loader version

Forge 43.2.21

Fabric API version

No response

In what kind of world or server did the problem occur?

My singleplayer world that I opened to LAN

What went wrong? (Crash logs don't go here)

sneaking doesn't take into account first person model's offset first person model dev said it was an issue on Pehkui's end worked fine for a day or two when using them together but one day broke and I wasn't able to fix it

image

Full list of installed mods and their version numbers

A.V.A - Alliance of Valiant Arms Guns 2.2.791 Additional Entity Attributes 1.0.1.+1.19 Apoli 1.10.2-2.6.1.1 AppleSkin 2.4.2+mc1.19 Applied Cooking 2.0.3 Applied Energistics 2 12.9.5 Architectury 6.5.85 Balm 4.5.7 Bookshelf 16.3.20 BotanyPots 9.0.33 Caelus API 1.19.2-3.0.0.6 Calio 1.19.2-1.7.01 Carry On 2.0.5.17 Cloth Config v8 API 8.3.103 Collective 6.65 Connectivity Mod 1.19.2-4.4 Controlling 10.0+7 CookingForBlockheads 13.3.2 CosmeticArmorReworked 1.19.2-v1a Cucumber Library 6.0.7 Essential 13437+deploy-staging+gd2fc09762 Farmer's Delight 1.19.2-1.2.3 FarmingUtils 1.19.2-0.1.4 Fastload 8.2.1+1.19.2 FirstPersonModel Mod 2.2.3-mc1.19.2 FPS Reducer 1.19.2-2.1 Just Enough Items 11.6.0.1016 Mekanism 10.3.9 Mekanism: Additions 10.3.9 Meknaism: Generators 10.3.9 Mekanism: Tools 10.3.9 Minecraft Comes Alive 7.5.5+1.19.2 MixinExtras 0.2.0-beta.6 Mouse Tweaks 2.23 MrCrayfish's Furniture Mod 7.0.0-pre35 Mystical Agriculture 6.0.11 Origins 1.19.2-1.7.1.1 Origins++ 2.1.1-forge Origins: Classes 1.2.0 Patchouli 1.19.2-66 Pehkui 3.7.8+1.19.2-forge Sebastrn Lib 2.0.2 Sophisticated Backpacks 1.19.2-3.18.55.889 Sophisticated Core 1.19.2-0.5.83.394 TheMillman Lib 1.19.2-0.1.0 Village Spawn Point 4.0 Wildfire's Female Gender Mod 1.19-3.0.0 Xaero's Minimap 23.6.0 Xaero's World Map 1.31.0 XL Packets 1.18.2-2.1

Did the problem cause the game to crash?

No.

Full crash report contents (if you experienced a crash)

Crash report output:

Aceplante commented 11 months ago

Yea this has been happening for a while with no fix in sight

tr7zw commented 8 months ago

Managed to look into it now: https://github.com/Virtuoel/Pehkui/blob/forge/1.20.1/src/main/java/virtuoel/pehkui/mixin/client/compat115plus/PlayerEntityRendererMixin.java this entirely overwrites my offset logic. So, I probably will make my mixin a higher priority and add a workaround.