Voldrix / onlyfans-dl-2

OnlyFans content downloader v2
GNU General Public License v3.0
151 stars 23 forks source link

Better feedback #15

Open Sgt-Nukem opened 3 years ago

Sgt-Nukem commented 3 years ago

Two suggestions:

a)

I was a bit bewildered when I ran the script for the first time:

Downloading content to XXX
Found 87 posts
Downloaded 80 new posts
Found 3 messages
Downloaded 1 new messages

Expectation: As I did not specifiy a max-age argument I was expecting it would download 100% of the stuff.

I just found out on the website that 2 of the 3 messages needed further payment.

So IMHO better feedback would be something like this:

Downloading content to XXX
Found 3 messages
2 messages are not yet paid
Downloaded 1 new messages

(I'm not sure if the same holds true for the posts though?)

b)

Running with the ubiquitous --help argument just produces:

C:\_OnlyFans_>python onlyfans-dl-2\onlyfans-dl.py --help

USER_ID auth failed, trying without it...
(if this persists you can comment out the USER_ID variable)

ERROR: User not found

That made me think I had the settings like USER_ID etc. in the script wrong, when in fact I did not.

Better check for --help /? etc. and pretend no arguments were given so the help text is shown.

blmatthews commented 2 years ago

I think part of the problem might be how it counts. I just ran it and get:

Downloading content to XXX
Found 477 posts
Downloaded 727 new posts
[...]

One might reasonably ask how it downloaded 727 new posts when there were only 477 total. However:

$ find XXX/photos -type f | wc -l
     641
$ find XXX/videos -type f | wc -l
      86

which add up to 727. So I suspect in "Found \ posts", \ is the number of posts. But in "Downloaded \ new posts", \ is the number of items (photos or videos) downloaded, so if each post doesn't contain exactly one photo or video, the two numbers won't match. If downloaded is less than found, maybe some posts only contain text?

Anyways, I agree that the feedback could be better to make it clearer exactly what the counts are counting.