Dynamic help view - Githubissues

WEKIT-ECS / MIRAGE-XR

MirageXR is a reference implementation of an XR training system. MirageXR enables experts and learners to share experience via XR and wearables using ghost tracks, realtime feedback, and anchored instruction.

Other

27 stars 4 forks source link

Dynamic help view #1113

Closed robhillman97 closed 1 year ago

robhillman97 commented 1 year ago

Adds the help view.

closes #964

fwild commented 1 year ago

Can we approve this? So we can test? I agree with reworking it a little, and agree that the variable names should be fixed first - but if there are bigger changes (more event driven processing, e.g.), then we should do them after - so we can already engage in testing this new feature, which most certainly will yield some additional changes (at least to the help texts!)

cawke commented 1 year ago

please test on different resolutions

fwild commented 1 year ago

I am sure this help view will have some additional things to resolve - but we cannot inspect it if we cannot test it. Can, @robhillman97 can you please build a test build (android)? And @cawke maybe we could please have this on ipad, too?

robhillman97 commented 1 year ago

@fwild there is an APK here; https://drive.google.com/drive/folders/1U_VQ2UF6DszvKkUZJhY3F01cEbsYVBC9?usp=sharing

fwild commented 1 year ago

@robhillman97 - how far are you away from finalising this pull request? Using Alex's refactored tutorial manager?

robhillman97 commented 1 year ago

I haven't made changes to this branch since the last commit. The functionality of the dynamic help works here but using the old tutorial style. I was under the impression that the new method is to be implemented by Boris, so I am not really sure where that leaves this branch now. If we're using the new manager for dynamic help it would probably be best to scrap this branch, create a new branch from made from "ashubin/Tutorial" and start again.

fwild commented 1 year ago

@robhillman97 can you please check with Boris - and maybe help him, if he cannot do it for the xmas release in time? Might be an idea to merge this PR into the tutorial branch on which Boris is working now?