search

WEKIT-ECS / MIRAGE-XR

MirageXR is a reference implementation of an XR training system. MirageXR enables experts and learners to share experience via XR and wearables using ghost tracks, realtime feedback, and anchored instruction.
Other
27 stars 4 forks source link

Improve shadows to not pixel #460

Closed wekitecs closed 2 years ago

wekitecs commented 2 years ago

In GitLab by @wild on Jun 7, 2021, 20:59

At the moment, any shadow in the system pixels a lot - looking especially weird on 3D models. Must be possible to improve this?

wekitecs commented 2 years ago

In GitLab by @BorisJov on Sep 15, 2021, 18:18

To be done in Sprint 11 if it's a quick fix.

wekitecs commented 2 years ago

In GitLab by @wild on Sep 20, 2021, 21:27

Still an issue in 1.6.102, I am reopening the ticket.

shadows-20210920_122622_HoloLens

wekitecs commented 2 years ago

In GitLab by @wild on Sep 20, 2021, 21:28

Can best be tested with the "ECG" experience: if you see the hospital bed, and the shadows pixel like in the pic above - then it still is an issue.

wekitecs commented 2 years ago

In GitLab by @a85jafari on Sep 20, 2021, 22:50

The shadows are very sharp in editor image

wekitecs commented 2 years ago

In GitLab by @a85jafari on Sep 20, 2021, 22:52

The quality is set to very low for Hololens! image

wekitecs commented 2 years ago

In GitLab by @a85jafari on Sep 20, 2021, 22:54

I change it now so you can test it again.

wekitecs commented 2 years ago

In GitLab by @BorisJov on Sep 21, 2021, 24:06

@wild I've merged it to develop, but wait your confirmation that it's done now

wekitecs commented 2 years ago

In GitLab by @wild on Sep 21, 2021, 08:55

version 1.6.104?

wekitecs commented 2 years ago

In GitLab by @wild on Sep 21, 2021, 09:03

looking better in 1.6.104 - but the shadow on the light rail is still rather pixeled.

wekitecs commented 2 years ago

In GitLab by @a85jafari on Sep 21, 2021, 10:14

Improving quality for Hololens can affect the performance! Should I try?

wekitecs commented 2 years ago

In GitLab by @wild on Sep 21, 2021, 10:19

definitely try! if it is slowing down too much, we will have to put it back. at the moment, the shadows are not truly bad anymore, but they are also not what one would expect these days.

wekitecs commented 2 years ago

In GitLab by @BorisJov on Sep 21, 2021, 16:36

@wild The settings have been changed again. Can we close the issue now?

wekitecs commented 2 years ago

In GitLab by @wild on Sep 28, 2021, 16:58

Shadows are still very pixely - the graphics are much improved, but the shadows seem unaffected from this.

wekitecs commented 2 years ago

In GitLab by @a85jafari on Oct 8, 2021, 14:46

@wild The problem is that the objects on Hololens can be seen very larger than other devices by user. It is the same about shadows. I testes some of Hololens apps and noticed non of them have real time shadows! So I think we need disable shadows on Hololens. Have you seen any app on Hololens with high quality real time shadowing?

wekitecs commented 2 years ago

In GitLab by @a85jafari on Oct 8, 2021, 15:12

With same shadow setting on Android, the shadows are very sharp.

image

wekitecs commented 2 years ago

In GitLab by @a85jafari on Oct 11, 2021, 11:39

@wild Shadows are disabled on Hololens. I think this is the best solution at the moment.

wekitecs commented 2 years ago

In GitLab by @wild on Oct 11, 2021, 13:11

ok, that seems reasonable. Please close ticket when merged.