search

WGBH-MLA / stock-sales-2

Public Stock Sales Site
Apache License 2.0
0 stars 2 forks source link

Program records #334

Closed mccalluc closed 7 years ago

mccalluc commented 8 years ago

@AlisonCSmith : Here are some changes that make it possible to have a special view for programs.

screen shot 2016-06-29 at 2 41 45 pm screen shot 2016-06-29 at 2 42 31 pm
AlisonCSmith commented 8 years ago

Hi Chuck:

  1. Not sure I understand what you mean by your question "are you comfortable combining the 2 databases"?
  2. Image sizes; Will it look too ragged to just leave them as different sizes? And/or screw us up in terms of layout?
  3. I would have an additional "card" entitled "WGBH series" (which can cover a multitude of sins...)
  4. Text: "This program is not yet clipped and may contain third party material. Please contact us to license a clip from the program and reference title and series.
  5. Add contact button in the field
mccalluc commented 8 years ago
mccalluc commented 8 years ago

Image manipulation remains to be done, but everything else is covered.

mccalluc commented 8 years ago

@AlisonCSmith : What are the values for Series names that will be coming in from the rights DB? For a given series, will the name always be the same, or are there any sub-series?

mccalluc commented 8 years ago

Added a placeholder if the series is not recognized:

screen shot 2016-07-01 at 2 56 36 pm

I think this is all the code work required. I believe this could be safely deployed, and reindexed with the new data, at any point.

mccalluc commented 8 years ago

@foo4thought : This PR has a solr schema change that the ruby code relies on. I think the safest thing would be to spin up a new server, but it could also probably be done on the current server, if we can tolerate a little downtime. Do you want to choose a course forward, and then I'll help you go through it?

(Stock sales does not use the server swapping strategy that we have in place for the other sites; perhaps it should.)

foo4thought commented 8 years ago

changing the solr schema seems like a big deal with lots of potentially hard-to-foresee consequences; I like the notion of testing such change on an "offline" instance of the app

mccalluc commented 7 years ago

@foo4thought : do you want to set up a new server so we can see what this looks like? How should we move this forward?

afred commented 7 years ago

@foo4thought @Muraszko @AlisonCSmith ... picking up the conversation where @mccalluc left off...

I'm in favor of setting up a workflow for Stock Sales similar to that of other sites, where we deploy first to a "demo" server for QA and then make it "go live".

This will take some time to set up, whether we implement the same infrastructure machinery as our other sites, or whether we do something simpler.

If we need the PR to be live before taking the time to set this up, then we'd be looking at just running the deployment script as it's currently set up, followed by an ad-hoc QA session. If we discover any bugs, we could try to "fall forward" and fix them quickly, or try to rollback. In either case, the site would be down during any repairs.

AlisonCSmith commented 7 years ago

Hello all, I know that Chuck is very busy finishing up his last hours of work here. A couple of points and questions:

  1. We are not in a great rush; we can take the time required to set up the demo server
  2. How long would it take to set up the demo server and what kind of cost would be involved?
  3. Should we decide to go forward without the demo server, do you have any idea how much time potentially the site could be down?

Thank you! Alison

Be sure to visit our website: www.wgbhstocksales.org WGBH: The Power of Public Media

From: Andrew Myers notifications@github.com<mailto:notifications@github.com> Reply-To: WGBH/stock-sales-2 reply@reply.github.com<mailto:reply@reply.github.com> Date: Monday, July 18, 2016 at 1:45 PM To: WGBH/stock-sales-2 stock-sales-2@noreply.github.com<mailto:stock-sales-2@noreply.github.com> Cc: Alison Smith alison_smith@wgbh.org<mailto:alison_smith@wgbh.org>, Mention mention@noreply.github.com<mailto:mention@noreply.github.com> Subject: Re: [WGBH/stock-sales-2] Program records (#334)

@foo4thoughthttps://github.com/foo4thought@Muraszkohttps://github.com/Muraszko @AlisonCSmithhttps://github.com/AlisonCSmith ... picking up the conversation where @mccalluchttps://github.com/mccalluc left off...

I'm in favor of setting up a workflow for Stock Sales similar to that of other sites, where we deploy first to a "demo" server for QA and then make it "go live".

This will take some time to set up, whether we implement the same infrastructure machinery as our other sites, or whether we do something simpler.

If we need the PR to be live before taking the time to set this up, then we'd be looking at just running the deployment script as it's currently set up, followed by an ad-hoc QA session. If we discover any bugs, we could try to "fall forward" and fix them quickly, or try to rollback. In either case, the site would be down during any repairs.

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/WGBH/stock-sales-2/pull/334#issuecomment-233403290, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AOHrFpfKs4h6BytCD9rXXbUredBYiz3nks5qW7vIgaJpZM4JBcsw.

afred commented 7 years ago

Conversation moved to email

mccalluc commented 7 years ago

Closing old stale PRs. I won't touch the branch, so if you want to open a new one, feel free. I probably do not need to belong to the WGBH org.

afred commented 7 years ago

thanks @mccalluc. Yes, we'll get you out of the Github org soon. But if you can close tix you know are stale, and save us a few cycles for trying to ascertain that for ourselves, then much obliged!