search

WIPACrepo / wipac-telemetry

WIPAC Telemetry: Monitoring/Tracing Applications, Supporting Infrastructures, and Services
MIT License
0 stars 0 forks source link

Pin `protobuf >= 3.13.0, < 4.0` #58

Closed ric-evans closed 2 years ago

ric-evans commented 2 years ago

Examples are failing: https://app.circleci.com/pipelines/github/WIPACrepo/wipac-telemetry/250/workflows/72fd8fe0-7e4e-465b-8305-1e8aa105fb28/jobs/233

ric-evans commented 2 years ago

TODO: if example(s) fail, job should fail

blinkdog commented 2 years ago

Examples are failing: https://app.circleci.com/pipelines/github/WIPACrepo/wipac-telemetry/250/workflows/72fd8fe0-7e4e-465b-8305-1e8aa105fb28/jobs/233

Ahhh, I see what you mean. The examples are failing, but that failure is being eaten by CircleCI and reported as success. :thinking:

dsschult commented 2 years ago

I'm guessing the examples script needs set -e or something, so it propagates errors up.

ric-evans commented 2 years ago

alas, the correct failure

dsschult commented 2 years ago

https://github.com/open-telemetry/opentelemetry-python/issues/2717

Upstream says to just pin the version for now.