search

WP-API / new-list-tables

An experiment in re-writing the post list screen using the REST API.
GNU General Public License v2.0
71 stars 17 forks source link

Improve the usage of the buttons CSS classes #10

Closed afercia closed 7 years ago

afercia commented 7 years ago

The button-secondary CSS class is deprecated and still in WP core just for backwards compatibility reasons.

The buttons CSS classes are "stackable", that means the base class is button and then other classes can be added as modifiers.

Worth noting, using only the button-secondary CSS class results in a wrong focus style applied to buttons and buttons are not responsive (they should become bigger in the responsive view).

For reference, see the comment in the wp-includes/css/buttons.css file.

rmccue commented 7 years ago

I think this code was taken directly from WP_Comments_List_Table? Easy enough to fix anyway.

afercia commented 7 years ago

Yep, a while ago core was still using button-secondary in a few places, see https://core.trac.wordpress.org/ticket/37138