search

WP-API / new-list-tables

An experiment in re-writing the post list screen using the REST API.
GNU General Public License v2.0
71 stars 17 forks source link

"Update Comment" and "Cancel" should be buttons #9

Closed afercia closed 7 years ago

afercia commented 7 years ago

Currently, "Update Comment" and "Cancel" are links without a href attribute, they're rendered, for example. as:

<a class="save button-primary alignright"><span id="savebtn">Update Comment</span></a>
<a class="cancel button-secondary alignleft">Cancel</a>

Since they don't point to any resource and they perform an action instead, they should be buttons. See also #5 for more details.

Worth noting at the moment these links are not operable when using a keyboard because <a> elements without a href attribute aren't focusable.