search

WPRDC / wprdc-etl

MIT License
8 stars 3 forks source link

Add xls exractor #46

Closed saylorsd closed 8 years ago

bsmithgall commented 8 years ago

Can you add a test case for the new job?

saylorsd commented 8 years ago

@bsmithgall Test added. Though I used FileConnector because I can't think of an effective way to mock an SFTP server.

also: the mock file just has one item as that's all they have available. Once the add some more rows, I'll fill out that file a bit more/

bsmithgall commented 8 years ago

I think there should be mock connectors somewhere in the test base.

bsmithgall commented 8 years ago

This also fixes #34

saylorsd commented 8 years ago

@bsmithgall You fine with merging this, closing the issues, and opening a new one for testing abestos_permits_pipeline with a mock SFTP? I'd like to get an instance running on our staging server for the jobs we have going. And then I can look into how to properly mock an SFTP server as I haven't had any immediate success.

bsmithgall commented 8 years ago

This looks good to me!