search

WPRDC / wprdc-etl

MIT License
8 stars 3 forks source link

add kane_census job and license #50

Closed saylorsd closed 8 years ago

saylorsd commented 8 years ago

…. updated readme to account for new config format

bsmithgall commented 8 years ago

:+1: Looks good to me.

This also fixes #22

saylorsd commented 8 years ago

@bsmithgall What timing! Thanks for taking a look. However, I just pushed a small change where extractor.create_schema_headers() removes trailing whitespace as it ended up being an issue with some of the source files we're receiving.

bsmithgall commented 8 years ago

New patch looks good as well, though you might want to add some unit tests to prevent future regressions.

saylorsd commented 8 years ago

As in to ensure that it make the proper formats, strippings and replacements?

bsmithgall commented 8 years ago

Yup.