search

WaelHamze / dyn365-ce-vsts-tasks

VSTS Extension for Dynamics 365 Customer Engagement
https://marketplace.visualstudio.com/items?itemName=WaelHamze.xrm-ci-framework-build-tasks
GNU General Public License v3.0
115 stars 54 forks source link

Solution Checker Critical Threshold Ignored #276

Open filcole opened 1 year ago

filcole commented 1 year ago

Hi Wael,

I noticed that the critical threshold is ignored by the solution checker quality gate task. I think this is because the CriticalThreshold is not included in the CheckParams object that's passed to the CheckerQualityGate.ps1 script.

See here: https://github.com/WaelHamze/dyn365-ce-vsts-tasks/blob/19a2b913d56e80c8a53b6999b82dbbe2cf372b2d/BuildTools/Xrm.CI.Framework.BuildTools/Tasks/MSCRMCheckerQualityGate/MSCRMCheckerQualityGate.ps1#L62

WaelHamze commented 1 year ago

@filcole thanks for flagging this will take a look