search

Wakamai-Fondue / wakamai-fondue-engine

The engine that powers Wakamai Fondue
Apache License 2.0
46 stars 9 forks source link

Return a font's example text #12

Closed RoelN closed 4 years ago

RoelN commented 4 years ago

Based on https://github.com/Wakamai-Fondue/wakamai-fondue-engine/pull/9, merge that first

RoelN commented 4 years ago

@pascalw Is this worth adding a test for?

pascalw commented 4 years ago

Yeah I would add a test for this. Should take a few minutes only and could prevent surprises down the road.

RoelN commented 4 years ago

Need to add a test font with a custom text first, these are quite rare 😆

pascalw commented 4 years ago

Ok well if it that's difficult I'm not opposed to not covering it.

RoelN commented 4 years ago

@pascalw Added a name table entry to our test font anyway. Then found out Font.js does indeed return strings intermixed with x00 bytes. I'm now stripping them out on our side, until https://github.com/Pomax/Font.js/issues/74 is addressed.

~Will fix the conflict after https://github.com/Wakamai-Fondue/wakamai-fondue-engine/pull/9 is merged.~

pascalw commented 4 years ago

Nice catch @RoelN !