Exclude @font-face from generated CSS

Wakamai-Fondue / wakamai-fondue-engine

The engine that powers Wakamai Fondue

Apache License 2.0

51 stars 12 forks source link

Exclude @font-face from generated CSS #57

Closed RoelN closed 3 years ago

RoelN commented 3 years ago

This is needed for Google Fonts. I only implemented this specifically for @font-face, but this should be expanded to enable further fine-tuning of the CSS (exclude Unicode range, variable stuff, layout features stuff, etc.).

Also, tests should be added, and optionally the cssString gettter should be deprecated.

RoelN commented 3 years ago

@pascalw Thanks for the review and the thorough suggestions! There will be more options, so we need to pick either one of your suggestions. I'm leaning towards the first option as it feels more straightforward.

For now I moved this to https://github.com/Wakamai-Fondue/wakamai-fondue-engine/issues/61 so I can merge this, so the GF stuff will look and work properly for now.