search

Wakamai-Fondue / wakamai-fondue-engine

The engine that powers Wakamai Fondue
Apache License 2.0
46 stars 9 forks source link

Requirement of inflate/pako #58

Open themesociety opened 3 years ago

themesociety commented 3 years ago

I was testing now with a lot of fonts and i never got any errors when just removing inflate/pako. Is there a way to trigger this or is it known for which use cases i need it?

Thanks a lot for the work on Wakamai, helped a lot to integrate lib-font in our project.

RoelN commented 3 years ago

I observed this too: https://github.com/Pomax/lib-font/issues/66 It's still on the to-figure-out-list :-)

If there's anything you can publicly share, @themesociety, I'd love to hear more about your project!

themesociety commented 3 years ago

Hi @RoelN,

that is good to know, i will keep it removed for now since i wasn't getting in any trouble so far.

I will use the lib-font for semplice.com, a portfolio website builder. At the moment we are adding support for variable webfonts and the problem was that after uploading a font you first had to set it to variable and then you would need to find (which is sadly not as easy as you may think) the axis information from the vendor and add them manually one by one.

Now with lib-fonts you can just drag and drop your fonts in and you are done. Your project was a great inspiration for that and it was even better to discover that you shared on how you achieved it.

Since i only need it for the fvar table i removed all other tables.

Here you can see it in action: https://share.getcloudapp.com/llu9PJjG

RoelN commented 3 years ago

@themesociety That is really cool! Nice work, looks slick. Great to see @Pomax' excellent work being put to good use.

themesociety commented 3 years ago

Thank you @RoelN! You are right that @Pomax really did an awesome work, i hope we can use more features of the lib in the future besides getting the axis from variable webonts.

Pomax commented 3 years ago

Note that I have a question for both of you in https://github.com/Pomax/lib-font/issues/66 though =)

WOFF/WOFF2 permits compression, but it does not require it, so are we sure that the fonts being used are actually using compression? (because if not, it will 100% look like inflate/pako aren't necessary, right up to the point where you try to load in a per-table compressed font, and the parser starts to interpret what is effectively garbage data as if it's real data ;)