Open Robbert opened 4 weeks ago
Thanks Robbert! 🙏
I think there's something wrong with the linter/prettier, as running npm run prettier
makes changes we don't want, like " → '. Likewise for npm run lint-fix
.
Also npm run lint
gives ERROR: "lint:prettier" exited with 1.
🤔
The rest of the changes look reasonable to me, but I'd love an extra pair of eyes on this. Maybe @Ryuno-Ki would like to do the honors?
Oops, I accidentally already created a PR.
To do:
fix eslint no-useless-escape issues
removes regexp escapes. However the existing ESLint config specifically disables this rule. Is there a reason the escapes are actually needed? In that case:no-useless-escape
in the new eslint configfetch
is now available in Node.js, and theshim-fetch.js
fromlib-font
is no longer being used. This causes all tests to fail, because local paths are treated differently. I'm not sure if this is a breaking change, or if thefromPath
function is already broken in Node 22 in the current release.fromPath
andfromDataBuffer
.fromPath
is uses in Node.js only, andfromDataBuffer
is used in the browser mainly. MakingfromPath
Node.js only makes sense to me. For browser support I suggest adding a newfromURL
API.