search

Wandalen / wretry.action

Retry action for Github CI
MIT License
93 stars 20 forks source link

Command to run before retry #165

Open Vampire opened 1 month ago

Vampire commented 1 month ago

I was considering nick-fields/retry and this action for doing a run step retry. From what I have read I prefer this action as it also supports other actions for the case I need it. But there is one feature the other action has, that is missing here and might be helpful. You can specify a command that is executed before a retry is tried. This can for example be used to clean up the state before doing the retry. Would be nice if you could add a similar or same possibility.

dmvict commented 1 month ago

Hello @Vampire

Thank you for the issue. I think it is possible to add the feature. I'm too busy at the moment and cannot guarantee fast delivery.

For now I may give you a quick solution. It's using of extended shell script. Here is a page on StackOverflow.

Vampire commented 1 month ago

I don't see how that applies. It might in the narrow case when you use command if you add the cleanup to the end of the script. But if you run an arbitrary other action, this cannot work.

I don't need fast delivery for this, I don't need it right now. Just thought this will for sure come in handy in the future so thought I request it that it is maybe there when I actually need it. :-)

Vampire commented 1 month ago

Btw. you should imho NOT call it something with or similar to "cleanup". It can also be used for other purposes, for example logging a warning to GHA when a retry happened.