search

Web3Auth / mpc-core-kit

16 stars 4 forks source link

Make mpc sign recovery param unmodified #122

Closed ieow closed 4 months ago

ieow commented 5 months ago

recovery param modification should be handled by provider. remove modification for v3

 v= v+27
himanshuchawla009 commented 5 months ago

but wht if apps dont want to use our provider and rather wants to use provider like viem just like wht pancake swap is doing.

matthiasgeihs commented 5 months ago

but wht if apps dont want to use our provider and rather wants to use provider like viem just like wht pancake swap is doing.

They can always add back the +27? In fact, Pancake Swap are already checking for it (signing.ts#L41).

himanshuchawla009 commented 4 months ago

merged in v3