Factorkey validation and rehydration error

[lwin-kyaw]

This PR includes -

• check 'SHARE_DELETED' on getFactorKeyMetadata and metadata validation
• throw error instead of logging, for rehydration fail.
• validate current factor key before copy or create new shares

[ieow]

Can you elaborate the issue ? why the need to throw on rehydrate failed?

[lwin-kyaw]

Can you elaborate the issue ? why the need to throw on rehydrate failed?

Hi, we don't necessarily need to throw rehydration error as when rehydration failed, all the later steps will also fail (factor login, create factor, etc...). However throwing error on rehydration failed, can catch some errors in early stage and prevent users proceeding to other steps. Anyway, we have logged out the error message when there's an error during rehydration, so, I think it would be better if we could throw the error also. It will also help us to write better test cases.

Sample case on rehydration failure

• create first core kit with manualSync:true
• create factor (factorKey1) and don't commit the changes
• create second core kit and init (with default params, Mpc-Corekit will rehydrate with existing factorKey1 from sessionManager)
• during rehydrate, we try to get the metadata for factorKey1, but since we don't commit changes in first corekit, factor metadata is not available, resulting in rehydration failure