search

Web3Auth / mpc-core-kit

15 stars 4 forks source link

feat: add missing function to export ed25519 seed #160

Closed metalurgical closed 1 week ago

metalurgical commented 3 weeks ago

Resolves #157

matthiasgeihs commented 3 weeks ago

Revised the function comments. Also clarified that export seed is only available for ed25519 accounts that were using import key flow.

himanshuchawla009 commented 2 weeks ago

Revised the function comments. Also clarified that export seed is only available for ed25519 accounts that were using import key flow.

does this means that accounts created as default /without import wont be able to export seed?

metalurgical commented 2 weeks ago

Revised the function comments. Also clarified that export seed is only available for ed25519 accounts that were using import key flow.

does this means that accounts created with as default /without import wont be able to export seed?

I would have thought that the seed should always be available, to keep it implementation neutral. Appears not to be the case though.

matthiasgeihs commented 2 weeks ago

Yeah, this is because seed is not available when we just create account from shares. To have the seed, we need to start with generating the seed, which is our import seed flow.

Maybe we can further improve the documentation to clearly state that if the user wants the ability to export seed, it must generate seed on frontend and use import seed flow to initialize account.

matthiasgeihs commented 1 week ago

have extended documentation. i think a deeper explanation (about why ed25519 uses a seed and how that relates to the scalar) should be included in the docs.