WebAssembly / binaryen

Optimizer and compiler/toolchain library for WebAssembly
Apache License 2.0
7.44k stars 737 forks source link

Don't require explicit env var configuration #1910

Open mcandre opened 5 years ago

mcandre commented 5 years ago

Sourceable scripts like emsdk_env.sh make it more difficult to use emcc, particularly in automated environments such as Docker containers. Also, these setup scripts assume that a richer bash-like shell is available, while many Linux and UNIX systems use a different shell by default, such as ksh, mksh, dash, POSIX sh, csh, or rc.

Could we move more of these out of shell scripts and into more static files like *.CONF, *.YML, *.JSON, etc.?

... Speaking of Docker, could we get an official image with the emcc toolchain completely configured and ready to build out of the box? This would help CI systems to produce high quality WASM artifacts.

kripken commented 5 years ago

There's an unofficial docker here: https://hub.docker.com/r/trzeci/emscripten/ would be good to have an official one, I agree.