WebAssembly / wasi-keyvalue

27 stars 10 forks source link

updated draft #2

Closed Mossaka closed 1 year ago

Mossaka commented 1 year ago

Rendered version: https://github.com/WebAssembly/wasi-kv-store/blob/e0830360a0f0184b991aeb0eb7e6b342ad385e15/README.md Signed-off-by: GitHub noreply@github.com

danbugs commented 1 year ago

I think we need to discuss more if we really want bulk-get/bulk-put(and a missing bulk-delete) without transactions - will people really use the bulk-put function if it might fail and only put half of their keys? If we don't have transactions, I feel like we're gonna start to see a lot of people doing:

// ...
if kv.bulk_put(list_of_kv_pairs).is_err()) {
  kv.bulk_delete(list_of_kv_pairs);
}
// ...
ricochet commented 1 year ago

A place for inspiration and a place where this proposal will need to be incorporated: https://github.com/wasmCloud/interfaces/tree/main/keyvalue

Note, thar be dragons around some keywords in python (delete).

ricochet commented 1 year ago

There's a mismatch between the proposal name and the high-level interface ("wasi:kv" without store). I think this proposal should be renamed to wasi-kv. Store implies an expectation of persistence to storage, usually in a DB-like thing. Common implementations may also be virtual/in-memory or implemented using a filesystem.

It may be worth including a prototype of what the world files for this may look like.

Mossaka commented 1 year ago

I think this proposal should be renamed to wasi-kv

My concern is that wasi-kv might not be clear to people what this proposal is about. Maybe wasi-keyvalue is better?

autodidaddict commented 1 year ago

I think this proposal should be renamed to wasi-kv

My concern is that wasi-kv might not be clear to people what this proposal is about. Maybe wasi-keyvalue is better?

yeah I think not using the word store is the clarifying action there. I'm fine with wasi-keyvalue

Mossaka commented 1 year ago

I don't have permission to rename the repo to wasi-keyvalue. Ping @linclark for help~

linclark commented 1 year ago

Done!