Refactor and streamlining of the keyvalue interfaces

thomastaylor312 commented 3 months ago

This is a wide ranging PR focused on trimming down and streamlining the keyvalue interface. This was a collaborative effort between Spin maintainers (@kate-goldenring and @dicej), wasmCloud maintainers (@thomastaylor312), @lukewagner, @Mossaka, and many others. Some of the key changes include:

No more use of streams. Data fetched from KV stores is generally limited in its size and streams introduced additional complexity that we decided could be avoided right now, especially after comparing this to how the Spin and wasmCloud keyvalue interfaces functioned (which is what started this conversation in the first place)
All interfaces are now resources that take a handle to a bucket to construct them rather than passing the bucket parameter each time
Consistency levels are no longer part of the interface name (for now). See #32 for more details. This also clarifies what consistency level is expected for the store interface. Please note that this doesn't mean we won't support more consistency levels in the future, just that what is enumerated in store is the most common expectations based on what our projects users were doing as well as comparing other similar offerings across the space
Simplified the imports to 3 core interfaces

After noodling on it some more with involved parties, we decided to keep the watch interface in here as well, whereas we were initially thinking we could just use wasi:messaging instead.

thomastaylor312 commented 3 months ago

Ok, I think I have addressed most comments. @kate-goldenring @dicej would love to make sure you're still good with everything as well

thomastaylor312 commented 2 months ago

Heads up that I made one more commit with the changes discussed in https://github.com/WebAssembly/wasi-keyvalue/pull/41#discussion_r1548559842

thomastaylor312 commented 2 months ago

Ok, I have pushed an update for the list-keys to use a cursor. Please let me know how it looks

thomastaylor312 commented 2 months ago

Ok, looks like we have a good consensus! Going to go ahead and merge. If there were any other missing docs or issues, let me know and I'll open a follow up

WebAssembly / wasi-keyvalue

Refactor and streamlining of the keyvalue interfaces #41