Open gregrickaby opened 9 years ago
The difference is that the areas are stored to the options table. I guess we'd have to see if there is a reason that it needs to be saved as an option and not registered in the globals like WP does it with register_nav_menu. I like this proposed method as it would also jive along with what WordPress does and give a more flexible way to name areas.
@dustyf Right, and that's causing it's own set of issues: https://github.com/WebDevStudios/WDS-Simple-Page-Builder/issues/27
Should be fixed in branch feature/refactor-2. This will be merged to develop after more testing.
Underscores in area names still displaying for areas in admin. This is an easy fix, just need to do it.
You should just need to pass in the name as an argument when registering the area. Then it will display that instead with refactor-2
oh that's how it works. well if that's not done we can still just strip out underscores and hyphens on output.
On Fri, Oct 2, 2015 at 7:35 PM Dustin Filippini notifications@github.com wrote:
You should just need to pass in the name as an argument when registering the area. Then it will display that instead with refactor-2
— Reply to this email directly or view it on GitHub https://github.com/WebDevStudios/WDS-Simple-Page-Builder/issues/28#issuecomment-145191932 .
~c
me@chrisreynolds.io
It's done.
On Oct 2, 2015, at 9:09 PM, Chris Reynolds notifications@github.com wrote:
oh that's how it works. well if that's not done we can still just strip out underscores and hyphens on output.
On Fri, Oct 2, 2015 at 7:35 PM Dustin Filippini notifications@github.com wrote:
You should just need to pass in the name as an argument when registering the area. Then it will display that instead with refactor-2
— Reply to this email directly or view it on GitHub https://github.com/WebDevStudios/WDS-Simple-Page-Builder/issues/28#issuecomment-145191932 .
~c
me@chrisreynolds.io — Reply to this email directly or view it on GitHub.
When using a underscore,
register_page_builder_area( 'after_content' );
The underscore appears in the dashboard: https://www.dropbox.com/s/qm35hf890m17826/Screenshot%202015-08-11%2010.45.46.png?dl=0
Maybe we could use something similar to
register_nav_menu()
orregister_sidebar()