search

WebKit / standards-positions

WebKit's positions on emerging web specifications
https://webkit.org/standards-positions/
241 stars 18 forks source link

Pointer Lock Unadjusted Movement option #254

Open aprotyas opened 10 months ago

aprotyas commented 10 months ago

WebKittens

@marcoscaceres

Title of the spec

Pointer Lock Unadjusted Movement option

URL to the spec

https://github.com/w3c/pointerlock/pull/49

URL to the spec's repository

https://github.com/w3c/pointerlock

Issue Tracker URL

No response

Explainer URL

No response

TAG Design Review URL

No response

Mozilla standards-positions issue URL

https://github.com/mozilla/standards-positions/issues/448

WebKit Bugzilla URL

https://bugs.webkit.org/show_bug.cgi?id=218054

Radar URL

rdar://70587738

Description

This is an unmerged proposal that was discussed in this issue: https://github.com/w3c/pointerlock/issues/36

This feature is requested by gaming platforms on the web, and there is a work-in-progress implementation submitted by james-howard here: https://github.com/WebKit/WebKit/pull/17525.

Among other things, this proposed change introduces a Promise workflow.

aprotyas commented 10 months ago

James Hollyer had requested a position on the webkit-dev mailing list: https://lists.webkit.org/pipermail/webkit-dev/2020-October/031473.html.

Quoting their description:

This is a change to the Pointer Lock spec to allow for an option to disable
OS level mouse adjustments. This is a highly requested feature from multiple
new web based gaming platforms. While in trials of this feature a Promise
structure was requested and added.

Migrating the standards position discourse to this Github issue now.

annevk commented 9 months ago

@NavidZ @james-howard what is the status of https://github.com/w3c/pointerlock/pull/49? It seems like it hasn't been updated for over a year. This feature on its own seems reasonable, but it would be good if there was a finished specification.

NavidZ commented 9 months ago

@mustaqahmed might know better of the status. To the best of my knowledge, it was already implemented at least in Chromium.

james-howard commented 9 months ago

@annevk here's the situation as I understand it:

@marcoscaceres Said that WPT tests are a pre-req for merging the specification. I added some in my WebKit PR with the plan that they could be upstreamed to the WPT.

@reillyeon Said that having an implementation outside of Chromium would help. I've written a WebKit implementation that is under review. Please let's try to avoid deadlock here (can't merge the spec without multiple implementations, can't get multiple implementations without merging the spec).

annevk commented 9 months ago

The spec PR was last touched a year-and-half ago, has merge conflicts, and has multiple requests for changes. Those should be resolved in some way and none of that is blocked by a second implementation as far as I can tell.

james-howard commented 9 months ago

To my reading, the requests for changes in the spec are just about formatting and style. I don't see any open requests that would affect the implementation in my WebKit PR.

Can you clarify the order you would like to see things done in? Is getting the spec cleaned up and merged a prerequisite to getting my WebKit PR accepted? Is it a prerequisite to getting a standards position staked out here?

annevk commented 9 months ago

Landing something in WebKit behind a preference is not blocked on standards-positions. Enabling it by default can be though.

mustaqahmed commented 9 months ago

The spec PR was last touched a year-and-half ago, has merge conflicts, and has multiple requests for changes. Those should be resolved in some way and none of that is blocked by a second implementation as far as I can tell.

I agree. Let's continue the PR discussion in https://github.com/w3c/pointerlock/pull/49.

To the best of my knowledge, it was already implemented at least in Chromium.

That's correct.

naderslr commented 3 months ago

Any update on this? I have my game disabled on Firefox but I have a lot of users that want Firefox support. Any update on when is this ever planned on the future?

I'm looking for the unadjustmentMovement on Firefox pointerlock.

aprotyas commented 3 months ago

@naderslr please refer to https://github.com/mozilla/standards-positions/issues/448 for the Mozilla standards-position.

naderslr commented 3 months ago

@naderslr please refer to mozilla/standards-positions#448 for the Mozilla standards-position.

I opened it and I'm sorry I don't understand what's going on. They closed it or they will do it soon?

Thank you for your patience.