search

WebKit / standards-positions

WebKit's positions on emerging web specifications
https://webkit.org/standards-positions/
254 stars 22 forks source link

CSSPageRule to inherit from CSSGroupingRule #346

Open mstensho opened 6 months ago

mstensho commented 6 months ago

WebKittens

No response

Title of the spec

CSSOM: CSSPageRule to inherit from CSSGroupingRule

URL to the spec

https://www.w3.org/TR/cssom-1/#the-csspagerule-interface

URL to the spec's repository

No response

Issue Tracker URL

No response

Explainer URL

No response

TAG Design Review URL

No response

Mozilla standards-positions issue URL

No response

WebKit Bugzilla URL

No response

Radar URL

No response

Description

This is what the spec says. CSSPageRule should inherit from CSSGroupingRule, not directly from CSSRule - in order to support CSSMarginRule children. Mozilla is about to ship this change: https://bugzilla.mozilla.org/show_bug.cgi?id=1868215 We want to do this in Chromum: https://groups.google.com/a/chromium.org/g/blink-dev/c/GcVSUIG9BGk

How about WebKit?

annevk commented 6 months ago

This seems fine. @mdubet thoughts?

Ahmad-S792 commented 6 months ago

WebKit bug - https://bugs.webkit.org/show_bug.cgi?id=216940

mdubet commented 6 months ago

Seems reasonable. Note that this will be the first example of a class inheritingCSSGroupingRule which doesn't accept a style rule as a child it seems ?

mstensho commented 6 months ago

Matthieu Dubet @.***> writes:

Seems reasonable. Note that this will be the first example of a class inheritingCSSGroupingRule which doesn't accept a style rule as a child it seems ?

Yes, seems correct.

-- Morten Stenshorne, Software developer, Blink/Layout, Google, Oslo, Norway