WerewolvesRevamped / Werewolves-Roles

The role book for Werewolves Revamped
7 stars 8 forks source link

apothecary change #1370

Closed CrowdfordBot closed 1 month ago

CrowdfordBot commented 4 months ago

captainluffy: Just a small tweak to apothecary which I think makes it better. On the same night the poisoned target is dying, killing apothecary wouldn't cure it. That way they only have to stay alive 1 night instead of 2

CrowdfordBot commented 1 month ago

captainluffy: <@242983689921888256> is this change ok

CrowdfordBot commented 1 month ago

mctsts: does that happen right now?

CrowdfordBot commented 1 month ago

mctsts: that doesnt really make sense in the first place

CrowdfordBot commented 1 month ago

mctsts: if its an end-night attack it should be executed either way

CrowdfordBot commented 1 month ago

captainluffy: so its fine to change?

CrowdfordBot commented 1 month ago

mctsts: yea imo

CrowdfordBot commented 1 month ago

captainluffy: btw the new pr you made is a duplicate

CrowdfordBot commented 1 month ago

captainluffy: of this one https://github.com/WerewolvesRevamped/Werewolves-Roles/pull/1386

CrowdfordBot commented 1 month ago

mctsts: oops

CrowdfordBot commented 1 month ago

mctsts: im tired

CrowdfordBot commented 1 month ago

captainluffy: btw

CrowdfordBot commented 1 month ago

captainluffy: i need you to change the formalization for this change, i dont know how

CrowdfordBot commented 1 month ago

captainluffy: too many attributes

CrowdfordBot commented 1 month ago

captainluffy: https://github.com/WerewolvesRevamped/Werewolves-Roles/pull/1395

CrowdfordBot commented 1 month ago

mctsts: it seems done?

CrowdfordBot commented 1 month ago

mctsts: oh for apothecary

CrowdfordBot commented 1 month ago

mctsts: can you fix the FPC one

CrowdfordBot commented 1 month ago

mctsts: capitializationg or whatever

CrowdfordBot commented 1 month ago

captainluffy: you mean capitalize the word flute team?

CrowdfordBot commented 1 month ago

captainluffy: yeah i can do that

CrowdfordBot commented 1 month ago

mctsts: I think flute team and FP should be lower cased

CrowdfordBot commented 1 month ago

captainluffy: sure

CrowdfordBot commented 1 month ago

captainluffy: will do

CrowdfordBot commented 1 month ago

mctsts: apothecary seems to not even have this part to begin with

CrowdfordBot commented 1 month ago

mctsts: from what I can tell poisoned is a guaranteed death once applied

CrowdfordBot commented 1 month ago

captainluffy:

This will only happen if the Apothecary survives until the end of that night.

CrowdfordBot commented 1 month ago

captainluffy: oh you mean in the formalization

CrowdfordBot commented 1 month ago

captainluffy: i changed it to be the apothecary only needs to surive the night of applying the poison

CrowdfordBot commented 1 month ago

mctsts: i think i added the necessary thing now

CrowdfordBot commented 1 month ago

captainluffy: I meant if apothecary survives the night

CrowdfordBot commented 1 month ago

captainluffy: But ur other interpretation would be cool too

CrowdfordBot commented 1 month ago

captainluffy: If we also added that

CrowdfordBot commented 1 month ago

captainluffy: changed it after your review

CrowdfordBot commented 1 month ago

mctsts: What

CrowdfordBot commented 1 month ago

mctsts: I did not mean that

CrowdfordBot commented 1 month ago

mctsts: I don't think that change works

CrowdfordBot commented 1 month ago

captainluffy: would u like me to undo it

CrowdfordBot commented 1 month ago

captainluffy: alright done

CrowdfordBot commented 1 month ago

mctsts: im so confused what we are actually changing

CrowdfordBot commented 1 month ago

mctsts: I think it should be changed that anyone once poisoned dies, independent of apothecary living status

CrowdfordBot commented 1 month ago

captainluffy: Yeah so here's what I changed

CrowdfordBot commented 1 month ago

captainluffy: Original: Takes 2 nighgs to die of poison. Interrupted if apothecary dies in those 2 nights New: Once poisoned, they will not get unpoisoned. But apothecary poisons after all attacks are done, so it can be interrupted on the initial poisoning

CrowdfordBot commented 1 month ago

captainluffy: <@242983689921888256> would this make more sense if I said poisoning was a start day ability?

CrowdfordBot commented 1 month ago

mctsts: yes that would work

CrowdfordBot commented 1 month ago

captainluffy: Ok I'll go change it to say that

CrowdfordBot commented 1 month ago

captainluffy: Though formalization would need changing too

CrowdfordBot commented 1 month ago

mctsts: yeah it seems the thing I added did the opposite of what it was suppsoed to do

CrowdfordBot commented 1 month ago

mctsts: i think we just have to take my added line out and change the action timing

CrowdfordBot commented 1 month ago

mctsts: you can do it if you want or ill do it when youre done

CrowdfordBot commented 1 month ago

captainluffy: Better if you do it