Create a new user object in WhosPcRpl if it does not exist yet

WildPHP / irc-bot

A simple and modular PHP IRC bot

MIT License

84 stars 24 forks source link

Create a new user object in WhosPcRpl if it does not exist yet #166

Open NanoSector opened 3 years ago

NanoSector commented 3 years ago

This should increase reliability with hopefully no side effects. All user information should be in the WhosPcRpl message and thus creating users at this stage should be safe.

NanoSector commented 3 years ago

Upon further checks, the user object should be created upon the NamReply message. This change becomes redundant and the original behaviour might even be useful as a bug check.

I'll leave this open for now, it's probably best to investigate the proper chain of messages before acting on this. The issue originally linked had a deeper bug.