search

WildPHP / irc-bot

A simple and modular PHP IRC bot
MIT License
84 stars 24 forks source link

Fix PHP Fatal in Help.php #4

Closed Southparkfan closed 9 years ago

Southparkfan commented 9 years ago

I cloned a fresh clone of this repository, changed config.php, renamed it to config.local.php. Seems fine, until you run "php phpbot404.php", because I got this: PHP Fatal error: Can't use method return value in write context in ./Classes/Command/Help.php on line 62

This patch should fix it.

NanoSector commented 9 years ago

Please see https://github.com/super3/IRC-Bot/issues/65 Aka update your PHP version. Thanks for the PR though.

NanoSector commented 9 years ago

Since I'm doing major changes anyway, I'll take this into account as well.

Southparkfan commented 9 years ago

/me was a bit too fast with making a pull request :-).

I use Debian Wheezy with PHP 5.4, so updating PHP is not really possible (unless you use the testing/jessie/sid distributions, whatever you need to do).

NanoSector commented 9 years ago

That's fine. :) I run Arch Linux myself which has the latest PHP available, 5.6.something, and so does my server, so I didn't notice these errors while testing locally and on my server.

If you find more of those errors throughout your use of the bot, report them please; I have the habit of just dumping everything in empty(), including functions (which causes this error).

NanoSector commented 9 years ago

Fixed with #5.